Re: [Qemu-devel] [PULL 0/4] migration queue

[Juan Quintela <quintela@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> wrote:
> On 10 June 2014 17:31, Juan Quintela <quintela@redhat.com> wrote:
>> Hi
>>
>> This includes:
>>
>> - last two patches that remove version_minimum_id_old.
>>
>> - refactor of opening of files was already tested (this is test-vmstate only)
>> - v4 of flags in ram_load from Peter.
>>
>> Please, apply.
>>
>> Juan.
>>
>>
>> The following changes since commit 3334e929ae2d01e47c3e64757ee7fcf975cede94:
>>
>>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20140610-1' into staging (2014-06-10 12:06:17 +0100)
>>
>> are available in the git repository at:
>>
>>
>>   git://github.com/juanquintela/qemu.git tags/migration/20140610
>>
>> for you to fetch changes up to e59d8b1399705ea94d6e66040e37848c56cb4843:
>>
>>   vmstate: Refactor opening of files (2014-06-10 16:52:14 +0200)
>>
>> ----------------------------------------------------------------
>> migration/next for 20140610
>>
>> ----------------------------------------------------------------
>> Juan Quintela (3):
>>       savevm: Remove all the unneeded version_minimum_id_old (ppc)
>>       savevm: Remove all the unneeded version_minimum_id_old (x86)
>>       vmstate: Refactor opening of files
>>
>> Peter Lieven (1):
>>       migration: catch unknown flags in ram_load
>
> I'm afraid this doesn't seem to build on 32 bit:

grrrrr

Guess who is installing a 32bit guest.
I already build for all architectures on linux and cross-compile for
windows, clearly it is not enough.

Thanks, and sorry for the inconveniences.

Later, Juan.

>
> /root/qemu/arch_init.c: In function ‘ram_load’:
> /root/qemu/arch_init.c:1101:17: error: format ‘%llx’ expects argument
> of type ‘long long unsigned int’, but argument 2 has type ‘ram_addr_t’
> [-Werror=format]
> /root/qemu/arch_init.c:1113:17: error: format ‘%llx’ expects argument
> of type ‘long long unsigned int’, but argument 2 has type ‘ram_addr_t’
> [-Werror=format]
> /root/qemu/arch_init.c:1122:17: error: format ‘%llx’ expects argument
> of type ‘long long unsigned int’, but argument 2 has type ‘ram_addr_t’
> [-Werror=format]
> /root/qemu/arch_init.c:1129:30: error: format ‘%llx’ expects argument
> of type ‘long long unsigned int’, but argument 2 has type ‘ram_addr_t’
> [-Werror=format]
> cc1: all warnings being treated as errors
> make[1]: *** [arch_init.o] Error 1
>
> thanks
> -- PMM