All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>,
	akong@redhat.com, Fam Zheng <famz@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] active block commit bug?
Date: Thu, 05 Jun 2014 09:06:42 +0200	[thread overview]
Message-ID: <87ppinesxp.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <538FDC27.3020607@redhat.com> (Eric Blake's message of "Wed, 04 Jun 2014 20:55:35 -0600")

Eric Blake <eblake@redhat.com> writes:

> On 06/04/2014 08:09 PM, Fam Zheng wrote:
>
>>> Sounds like we have an off-by-one condition if empty files behave
>>> differently from other files.  We ought to fix that bug (not that your
>>> normal guest will ever have a 0-length backing file, but this was what I
>>> was trying to use for libvirt's probing of whether active commit is
>>> supported)
>>>
>> 
>> Yes, agreed, this special case is only going to make management confused. I
>> will send a patch to fix this.
>
> Thanks.
>
>> 
>> Eric, is this a good way to probe the active commit? I was expecting full
>> instrospection of QMP could do it, but I don't know about the status of that
>> piece of work. Amos, any ideas?
>
> Introspection already missed qemu 2.0 when active commit was added; and
> we're close enough to soft freeze for 2.1 that I'm guessing it will miss
> 2.1 as well :(

Almost certainly.  It has non-trivial design issues.  To have a chance
to make it into 2.x, it needs to be posted for review early in the 2.x
cycle.

[...]

  parent reply	other threads:[~2014-06-05  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 22:55 [Qemu-devel] active block commit bug? Eric Blake
2014-06-05  0:12 ` Jeff Cody
2014-06-05  1:54   ` Eric Blake
2014-06-05  2:09     ` Fam Zheng
2014-06-05  2:55       ` Eric Blake
2014-06-05  3:07         ` Fam Zheng
2014-06-05  7:06         ` Markus Armbruster [this message]
2014-06-05  8:25           ` Kevin Wolf
2014-06-05  9:21             ` Markus Armbruster
2014-06-06  5:30           ` Amos Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppinesxp.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=akong@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.