From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751347AbaELAuF (ORCPT <rfc822;w@1wt.eu>);
	Sun, 11 May 2014 20:50:05 -0400
Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:50126 "EHLO
	lgemrelse7q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750877AbaELAuD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 11 May 2014 20:50:03 -0400
X-Original-SENDERIP: 10.177.220.181
X-Original-MAILFROM: namhyung@gmail.com
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        David Ahern <dsahern@gmail.com>, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf tools: Use tid for finding thread
References: <1399429566-15587-1-git-send-email-namhyung@kernel.org>
	<20140511131542.GA2272@krava.brq.redhat.com>
Date: Mon, 12 May 2014 09:50:01 +0900
In-Reply-To: <20140511131542.GA2272@krava.brq.redhat.com> (Jiri Olsa's message
	of "Sun, 11 May 2014 15:15:42 +0200")
Message-ID: <87ppjjn7ly.fsf@sejong.aot.lge.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 11 May 2014 15:15:42 +0200, Jiri Olsa wrote:
> On Wed, May 07, 2014 at 11:26:06AM +0900, Namhyung Kim wrote:
>> I believe that passing pid (instead of tid) as the 3rd arg of the
>> machine__find*_thread() was to find a main thread so that it can
>> search proper map group for symbols.  However with the map sharing
>> patch applied, it now can do it in any thread.
>> 
>> It fixes a bug when each thread has different name, it only reports a
>> main thread for samples in other threads.
>
> and breaks tests 14 and 26 ;-)
>
> ...
> 14: Test matching and linking multiple hists               : FAILED!
> 15: Try 'use perf' in python, checking link problems       : Ok
> 16: Test breakpoint overflow signal handler                : Ok
> 17: Test breakpoint overflow sampling                      : Ok
> 18: Test number of exit event of a simple workload         : Ok
> 19: Test software clock events have valid period values    : Ok
> 20: Test converting perf time to TSC                       : Ok
> 21: Test object code reading                               : Ok
> 22: Test sample parsing                                    : Ok
> 23: Test using a dummy software event to keep tracking     : Ok
> 24: Test parsing with no sample_id_all bit set             : Ok
> 25: Test dwarf unwind                                      : Ok
> 26: Test filtering hist entries                            : FAILED!
> ...

Forgot to set sample->tid for those cases.  Will fix.

Thanks,
Namhyung