From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WheWY-0008ID-Qx for qemu-devel@nongnu.org; Tue, 06 May 2014 08:31:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WheWT-0001qw-C2 for qemu-devel@nongnu.org; Tue, 06 May 2014 08:31:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WheWT-0001qk-5e for qemu-devel@nongnu.org; Tue, 06 May 2014 08:31:01 -0400 From: Markus Armbruster References: <1399034675-17844-1-git-send-email-armbru@redhat.com> <1399034675-17844-9-git-send-email-armbru@redhat.com> <5367F909.7070501@redhat.com> Date: Tue, 06 May 2014 14:30:31 +0200 In-Reply-To: <5367F909.7070501@redhat.com> (Eric Blake's message of "Mon, 05 May 2014 14:48:09 -0600") Message-ID: <87ppjrt7h4.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 08/13] qapi: Un-inline visit of implicit struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com, vilanova@ac.upc.edu Eric Blake writes: > On 05/02/2014 06:44 AM, Markus Armbruster wrote: >> In preparation of error handling changes. Bonus: generates less >> duplicated code. >> >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi-visit.py | 48 ++++++++++++++++++++++++++++++++++-------------- >> 1 file changed, 34 insertions(+), 14 deletions(-) > > Too bad the example txt file didn't cover this case, to show the > difference in the generated code. Yes. I considered extending the example in docs/qapi-code-gen.txt, but I'm afraid our schema language has become too big for complete coverage in that example. tests/qapi-schema-test.json should use every schema language feature. The code generated for it isn't in git, though. To see diffs, so you have to apply patches, make check, and compare tests/test-q*.[ch] by hand. > Reviewed-by: Eric Blake Thanks!