All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Aaron Lu <aaron.lu@intel.com>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH] Default to using the native backlight control on Windows 8 systems
Date: Fri, 11 Apr 2014 13:58:57 +0300	[thread overview]
Message-ID: <87ppko6sjy.fsf@intel.com> (raw)
In-Reply-To: <534759CD.20405@intel.com>

On Fri, 11 Apr 2014, Aaron Lu <aaron.lu@intel.com> wrote:
> On 04/11/2014 04:13 AM, Matthew Garrett wrote:
>> The list of machines in the "Use native backlight" table is getting longer
>> and longer, which is a solid indication that we're doing something wrong.
>> Disable the ACPI backlight interface if the system claims to be Windows 8
>> or later.
>
> And has a native backlight control interface.

This. One thing we were doing wrong in i915 was unconditionally
registering a native backlight interface even when it was not
functional. We can't really know whether that is the case except by
trusting the VBT, and although we've been let down in the past, trusting
the VBT on this one is probably a better approximation of the reality
than assuming it always works. Thus we've queued [1] and [2] for 3.15
which should help.

[1] http://cgit.freedesktop.org/drm-intel/commit/?id=39fbc9c8f6765959b55e0b127dd5c57df5a47d67
[2] http://cgit.freedesktop.org/drm-intel/commit/?id=c675949ec58ca50d5a3ae3c757892f1560f6e896

>> Let's at least get this into -next for 3.16 and figure out whether the
>> drivers actually work now.
>
> I agree.

Agreed.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2014-04-11 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 20:13 [PATCH] Default to using the native backlight control on Windows 8 systems Matthew Garrett
2014-04-11  2:56 ` Aaron Lu
2014-04-11 10:58   ` Jani Nikula [this message]
2014-04-11 11:31     ` Aaron Lu
2014-04-21 20:55 ` Rafael J. Wysocki
2014-06-05 20:27 ` [PATCH] ACPI / video: Change the default for video.use_native_backlight to 1 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppko6sjy.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=aaron.lu@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.