From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1WVnFz-0002ck-Hl
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:25:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1WVnFq-0000qR-Ar
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:24:59 -0400
Received: from e23smtp07.au.ibm.com ([202.81.31.140]:47236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1WVnFp-0000pM-JY
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:24:50 -0400
Received: from /spool/local
	by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <nikunj@linux.vnet.ibm.com>;
	Fri, 4 Apr 2014 05:24:46 +1000
From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
In-Reply-To: <533DA210.2010303@redhat.com>
References: <1396544174-8904-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<533DA210.2010303@redhat.com>
Date: Fri, 04 Apr 2014 00:54:28 +0530
Message-ID: <87ppkyxllf.fsf@abhimanyu.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in
	case of -nodefaults
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, agraf@suse.com
Cc: aik@au1.ibm.com, Mark Wu <wudxw@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 03/04/2014 18:56, Nikunj A Dadhania ha scritto:
>> The following commit caused the regression in qemu-system-ppc64
>>
>> 7effdaa3: spapr: Fix return value of vga initialization
>> d44229c5: Fix vga_interface_type for command line argument '-device VGA'
>>
>> Even when -nodefaults was provided, USB Keyboard and Mouse was added
>> to the machine. This breaks libvirt which uses -nodefaults and adds
>> the keyboard and mouse separately. The machine got 2 USB Keyboards
>> and 2 USB Mouses.
>
> Does libvirt use "-nodefaults -machine usb=true"?  It should create the 
> OHCI controller separately instead of using "-machine".

I see it creating:

-nodefaults -usb -device usb-kbd,id=input0 -device usb-mouse,id=input1

And -usb is translated to adding "pci-ohci" controller for spapr

Regards,
Nikunj