From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/3] drm/dp: make aux retries less chatty Date: Tue, 18 Mar 2014 09:44:35 +0200 Message-ID: <87pplkymqk.fsf@intel.com> References: <1395114666-2052-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B7F2A6F0EF for ; Tue, 18 Mar 2014 00:53:20 -0700 (PDT) In-Reply-To: <1395114666-2052-1-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , dri-devel@lists.freedesktop.org Cc: Alex Deucher List-Id: dri-devel@lists.freedesktop.org On Tue, 18 Mar 2014, Alex Deucher wrote: > Switch to debug only to avoid flooding the logs. > This mirrors the behavior in some other drivers. I'd rather think we should find out why the DP devices are replying with repeated native or i2c-over-aux defers. This doesn't help; I'm not in favour. BR, Jani. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/drm_dp_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 35251af..74724aa 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -402,7 +402,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, > } > } > > - DRM_ERROR("too many retries, giving up\n"); > + DRM_DEBUG_KMS("too many retries, giving up\n"); > return -EIO; > } > > @@ -656,7 +656,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) > } > } > > - DRM_ERROR("too many retries, giving up\n"); > + DRM_DEBUG_KMS("too many retries, giving up\n"); > return -EREMOTEIO; > } > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center