All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH/RFC] perf ui/tui: Show column header in hist browser
Date: Thu, 16 Jan 2014 09:42:23 +0900	[thread overview]
Message-ID: <87ppns92q8.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140115141314.GA16016@ghostprotocols.net> (Arnaldo Carvalho de Melo's message of "Wed, 15 Jan 2014 11:13:14 -0300")

Hi Arnaldo and Jiri,

On Wed, 15 Jan 2014 11:13:14 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jan 15, 2014 at 01:10:44PM +0100, Jiri Olsa escreveu:
>> On Wed, Jan 15, 2014 at 02:08:45PM +0900, Namhyung Kim wrote:
>> > Add a line for showing column headers like --stdio.
>> 
>> https://git.kernel.org/cgit/linux/kernel/git/jolsa/perf.git/commit/?h=perf/lock12&id=1a06d77629cb8870838132688f443b9ca1436026
>> 
>> ;-) I'll check your change
>
> From a quick view, your change looks better, i.e. being able to toggle
> the header line.
>
> Please let me know what you guys end up agreeing is best.

Yes, looking at the source, Jiri's version looks much better.  I was
lazy for sorting column width and supporting a hotkey for toggling. :)
I just wanted to see how you guys think, so the rfc.

Thanks,
Namhyung

  reply	other threads:[~2014-01-16  0:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15  5:08 [PATCH/RFC] perf ui/tui: Show column header in hist browser Namhyung Kim
2014-01-15 12:10 ` Jiri Olsa
2014-01-15 14:13   ` Arnaldo Carvalho de Melo
2014-01-16  0:42     ` Namhyung Kim [this message]
2014-01-16  8:24       ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppns92q8.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.