From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>"Kirill A.
Shutemov" <kirill.shutemov@linux.intel.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com
Subject: Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling
Date: Mon, 09 Dec 2013 16:56:55 +0530 [thread overview]
Message-ID: <87ppp6b6yo.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131209102517.33F4EE0090@blue.fi.intel.com>
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> Kirill A. Shutemov wrote:
>> Currently we have few issues with P9_STATS_GEN:
>>
>> - We don't try to read st_gen anything except files or directories, but
>> still set P9_STATS_GEN bit in st_result_mask. It may mislead client:
>> we present garbage as valid st_gen.
>>
>> - If we failed to get valid st_gen with ENOTTY, we ignore error, but
>> still set P9_STATS_GEN bit in st_result_mask.
>>
>> - If we failed to get valid st_gen with any other errno, we fail
>> getattr altogether. It's excessive: we block valid client use-cases,
>> like chdir(2) to non-readable directory with execution bit set.
>>
>> The patch fixes these issues and cleanup code a bit.
>>
>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
>> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> Ping?
>
I am hoping that this will go to upstream directly without me doing a
pull request ? Anthony, let me know if this need anything to be done
from my side
-aneesh
next prev parent reply other threads:[~2013-12-09 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 11:56 [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling Kirill A. Shutemov
2013-12-09 10:25 ` Kirill A. Shutemov
2013-12-09 11:26 ` Aneesh Kumar K.V [this message]
2013-12-23 12:21 ` Kirill A. Shutemov
2014-01-07 10:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppp6b6yo.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aliguori@amazon.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.