All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jeremie Samuel <jeremie.samuel.ext@parrot.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: dove: Fix build breakage
Date: Sun, 27 Oct 2013 08:56:55 -0400	[thread overview]
Message-ID: <87ppqqkh2g.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1382533832-21085-1-git-send-email-treding@nvidia.com> (Thierry Reding's message of "Wed, 23 Oct 2013 15:10:32 +0200")

Hi,

On Wed, Oct 23 2013, Thierry Reding wrote:
> Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> converts tasklets to work structs, but typos the conversion in the Dove
> driver.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/mmc/host/sdhci-dove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> index 45c7f25..95f1076 100644
> --- a/drivers/mmc/host/sdhci-dove.c
> +++ b/drivers/mmc/host/sdhci-dove.c
> @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
>  {
>  	struct sdhci_host *host = data;
>  
> -	schedule_schedule(&host->card_detect_work);
> +	schedule_work(&host->card_detect_work);
>  	return IRQ_HANDLED;
>  }

Thanks, Thierry -- I hope it's okay with you if I merge your fix into
the original patch and add your S-o-b to that patch:

    Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
    Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com>
    [treding: Fix typo causing sdhci-dove build breakage]
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Chris Ball <cjb@laptop.org>

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

  parent reply	other threads:[~2013-10-27 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 13:10 [PATCH] mmc: sdhci: dove: Fix build breakage Thierry Reding
2013-10-23 13:45 ` Jeremie Samuel
2013-10-23 13:45   ` Jeremie Samuel
2013-10-27 12:56 ` Chris Ball [this message]
2013-10-28  7:47   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppqqkh2g.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=jeremie.samuel.ext@parrot.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.