All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Harald Servat <harald.servat@bsc.es>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: Changing frequency rate to perf mem
Date: Wed, 23 Oct 2013 22:12:00 -0700	[thread overview]
Message-ID: <87ppqvs15r.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <5267EE8E.3020306@bsc.es> (Harald Servat's message of "Wed, 23 Oct 2013 17:43:10 +0200")

Harald Servat <harald.servat@bsc.es> writes:
>
>   BTW, I tried to change this value by adding "-F" and "200" into the
> argv that is passed to cmd_report by adding
>
>         rec_argv[i++] = strdup("-F");
>         rec_argv[i++] = strdup("200");
>
>   into line 42 of perf-mem.c - just after the
> strdup("record").

You would need to increase the array size too.

> Unfortunately, this seems to break something and
> perf segfaults often. Which is the most appropriate way to tune the
> user frequency of perf mem?

Best would be probably to fix it to pass through unknown
options, then -F/-c could be just used. I'm not sure
if this is possible easily with the git option parser.

Alternatively you can just specify the command line perf mem record
would specify directly to perf record, plus -c/-F

-andi

-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2013-10-24  5:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 15:43 Changing frequency rate to perf mem Harald Servat
2013-10-24  5:12 ` Andi Kleen [this message]
2013-10-24  7:48   ` Harald Servat
2013-10-28  6:50     ` Namhyung Kim
2013-10-28  8:15       ` Harald Servat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppqvs15r.fsf@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=harald.servat@bsc.es \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.