From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEaiF-0006KW-QF for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:02:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEai7-0001D3-BM for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:02:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEai7-0001Ck-4y for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:02:39 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7S82bNr011398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Aug 2013 04:02:37 -0400 From: Markus Armbruster References: <1377631034-24409-1-git-send-email-bsd@redhat.com> <1377631034-24409-2-git-send-email-bsd@redhat.com> Date: Wed, 28 Aug 2013 10:02:35 +0200 In-Reply-To: <1377631034-24409-2-git-send-email-bsd@redhat.com> (Bandan Das's message of "Tue, 27 Aug 2013 15:17:13 -0400") Message-ID: <87ppsymeec.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/2] hda-codec: refactor common definitions into a header file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das Cc: qemu-devel@nongnu.org, Gerd Hoffmann Bandan Das writes: > Move common defines and structs to a header file. > We will then include these twice in hda-codec.c - > a version with mixer enabled and another with not enabled. Suggest: The next commit will include it twice, once for a device with a mixer, and once for device without a mixer. Actual patch is pure code motion.