From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Bfo-0002A6-KO for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:17:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4Bfj-0003Th-CS for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:17:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Bfj-0003TW-3s for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:17:11 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UFHA7Y027790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Jul 2013 11:17:10 -0400 From: Markus Armbruster References: Date: Tue, 30 Jul 2013 17:17:08 +0200 In-Reply-To: (Michal Novotny's message of "Tue, 30 Jul 2013 16:54:40 +0200") Message-ID: <87ppu06psb.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: qemu-devel@nongnu.org Michal Novotny writes: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer. Text from here > > The patch is checked using ./scripts/checkpatch.pl script and > also is_help_option() function is being used. > > Michal to here belongs below the '---' line, so it's ommitted from the commit message. > > Signed-off-by: Michal Novotny > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/vl.c b/vl.c > index 25b8f2f..563ae67 100644 > --- a/vl.c > +++ b/vl.c > @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) > if (machine) { > return machine; > } > + > + if (name && !is_help_option(name)) { > + printf("Error: Unsupported machine type '%s'\n", name); > + } > + > printf("Supported machines are:\n"); > for (m = first_machine; m != NULL; m = m->next) { > if (m->alias) {