Re: [Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test

[Markus Armbruster <armbru@redhat.com>]

Eric Blake <eblake@redhat.com> writes:

> On 07/26/2013 06:39 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  qapi-schema-test.json | 53 ---------------------------------
>>  tests/Makefile                          |  8 ++---
>>  tests/qapi-schema/qapi-schema-test.exit |  1 +
>>  tests/qapi-schema/qapi-schema-test.json | 53
>> +++++++++++++++++++++++++++++++++
>
> You don't have git rename detection turned on?  You get a more compact
> listing of file renames if you do:
> git config diff.renames true

Now I do.

> I just modified http://wiki.qemu.org/Contribute/SubmitAPatch to mention
> this tip.

Good move.

>>  tests/qapi-schema/qapi-schema-test.out  | 19 ++++++++++++
>>  5 files changed, 77 insertions(+), 57 deletions(-)
>>  delete mode 100644 qapi-schema-test.json
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.err
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.exit
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.json
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.out
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!