From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1V36rE-0001kK-JJ
	for qemu-devel@nongnu.org; Sat, 27 Jul 2013 11:56:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1V36rC-0001JE-DZ
	for qemu-devel@nongnu.org; Sat, 27 Jul 2013 11:56:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1V36Vq-0004rC-Ip
	for qemu-devel@nongnu.org; Sat, 27 Jul 2013 11:34:30 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1374842387-17146-1-git-send-email-armbru@redhat.com>
	<1374842387-17146-3-git-send-email-armbru@redhat.com>
	<51F276D4.1000104@redhat.com>
Date: Sat, 27 Jul 2013 17:34:25 +0200
In-Reply-To: <51F276D4.1000104@redhat.com> (Eric Blake's message of "Fri, 26
	Jul 2013 07:17:08 -0600")
Message-ID: <87ppu481a6.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as
	schema parser test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, akong@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Eric Blake <eblake@redhat.com> writes:

> On 07/26/2013 06:39 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  qapi-schema-test.json | 53 ---------------------------------
>>  tests/Makefile                          |  8 ++---
>>  tests/qapi-schema/qapi-schema-test.exit |  1 +
>>  tests/qapi-schema/qapi-schema-test.json | 53
>> +++++++++++++++++++++++++++++++++
>
> You don't have git rename detection turned on?  You get a more compact
> listing of file renames if you do:
> git config diff.renames true

Now I do.

> I just modified http://wiki.qemu.org/Contribute/SubmitAPatch to mention
> this tip.

Good move.

>>  tests/qapi-schema/qapi-schema-test.out  | 19 ++++++++++++
>>  5 files changed, 77 insertions(+), 57 deletions(-)
>>  delete mode 100644 qapi-schema-test.json
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.err
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.exit
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.json
>>  create mode 100644 tests/qapi-schema/qapi-schema-test.out
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!