From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1US001-0001Gp-1Y
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 03:08:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1URzzz-0000F8-Ig
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 03:08:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1URzzz-0000Eg-Ab
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 03:08:15 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3G78Eba010374
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 16 Apr 2013 03:08:14 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1366091252-16802-1-git-send-email-akong@redhat.com>
Date: Tue, 16 Apr 2013 09:08:12 +0200
In-Reply-To: <1366091252-16802-1-git-send-email-akong@redhat.com> (Amos Kong's
	message of "Tue, 16 Apr 2013 13:47:32 +0800")
Message-ID: <87ppxvosv7.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] monitor: fix the wrong order of releasing
	keys
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

Amos Kong <akong@redhat.com> writes:

> (qemu) sendkey ctrl_r-scroll_lock-scroll_lock
>
> Executing this command could not let Windows guest panic, it caused by

"could not"?

> the wrong order of releasing keys. This problem was introduced by
> commit e4c8f004c55d9da3eae3e14df740238bf805b5d6.
>
> The right release order should be starting from last item.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  ui/input.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/ui/input.c b/ui/input.c
> index 9abef0c..ecfeb43 100644
> --- a/ui/input.c
> +++ b/ui/input.c
> @@ -234,13 +234,11 @@ static void free_keycodes(void)
>  
>  static void release_keys(void *opaque)
>  {
> -    int i;
> -
> -    for (i = 0; i < keycodes_size; i++) {
> -        if (keycodes[i] & 0x80) {
> +    while (keycodes_size > 0) {
> +        if (keycodes[--keycodes_size] & 0x80) {
>              kbd_put_keycode(0xe0);
>          }
> -        kbd_put_keycode(keycodes[i]| 0x80);
> +        kbd_put_keycode(keycodes[keycodes_size] | 0x80);
>      }
>  
>      free_keycodes();