All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sergey Yanovich <ynvich@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Namjae Jeon <linkinjeon@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2] wait while adding MMC host to ensure root mounts
Date: Wed, 27 Mar 2013 07:57:34 -0400	[thread overview]
Message-ID: <87ppylf429.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CAPDyKFp27MUOjhydLXf92vN3cua=XcX4oTJnMGfOJPpBhtwM8Q@mail.gmail.com> (Ulf Hansson's message of "Wed, 27 Mar 2013 12:13:12 +0100")

Hi,

On Wed, Mar 27 2013, Ulf Hansson wrote:
> I noticed you merged this. I thought the idea was to use the rootwait
> or rootdelay?

That's necessary before the patch, but it would be better if we didn't
have to pass rootwait, all else being equal.

> Moreover, this patch will have bad impact on booting the kernel, since
> every host device that has scheduled a detect work from it's probe
> function will also wait for it to finish. Even if it is the boot
> device of not. If this is needed, I would prefer that a host cap is
> used.

I see, you're worried about a performance regression where every boot
takes longer than it used to while MMC quiesces.  That's fair.  Do you
think you could tell me how much delay this adds to a boot for you, so
that we can consider whether the usability improvement is worth it?

If the delay's significant, I agree with you and will revert this patch.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2013-03-27 11:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  1:06 [PATCH] wait while adding MMC host to ensure root mounts Sergey Yanovich
2013-03-14  1:23 ` [PATCH v2] " Sergey Yanovich
2013-03-14  4:08   ` Namjae Jeon
2013-03-14 11:57     ` Sergey Yanovich
2013-03-15  2:51     ` Jaehoon Chung
2013-03-22 17:03   ` Chris Ball
2013-03-27 11:13     ` Ulf Hansson
2013-03-27 11:57       ` Chris Ball [this message]
2013-04-02 13:36         ` Adrian Hunter
2013-04-02 14:24           ` Sergey Yanovich
2013-04-04  6:35             ` Adrian Hunter
2013-04-04 10:59               ` Sergey Yanovich
2013-04-04 11:35                 ` Adrian Hunter
2013-04-04 12:32                   ` Sergey Yanovich
2013-04-13 10:49         ` Sergey Yanovich
2013-04-13 12:52           ` Chris Ball
     [not found]           ` <CAPDyKFrF8pmo7mfa_1Vi2n=JBFd1h+VULQ1hJB75=DmNx0erdw@mail.gmail.com>
2013-04-13 12:52             ` Sergey Yanovich
2013-03-27 12:28       ` Сергей Янович
2013-04-02 10:13         ` Ulf Hansson
2013-04-02 10:35           ` Sergey Yanovich
2013-04-02 17:45             ` Ulf Hansson
2013-04-02 18:56               ` Sergey Yanovich
2013-03-14  2:47 ` [PATCH] " Greg Kroah-Hartman
2013-03-14 10:28   ` Sergey Yanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppylf429.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jh80.chung@samsung.com \
    --cc=linkinjeon@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=ynvich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.