From: Anthony Liguori <aliguori@us.ibm.com>
To: Knut Omang <knut.omang@oracle.com>, qemu-devel@nongnu.org
Cc: Avik Sil <aviksil@linux.vnet.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Add new DEFAULT_MACHINE_OPTIONS to q35 and ppc405
Date: Wed, 16 Jan 2013 08:53:34 -0600 [thread overview]
Message-ID: <87pq15ji1d.fsf@codemonkey.ws> (raw)
In-Reply-To: <1358339133.1949.6.camel@abi.no.oracle.com>
Knut Omang <knut.omang@oracle.com> writes:
> Without this default q35/ppc405 based machines would no longer boot
> after commit e4ada29e909787f629626660b1561f6a680187d3
>
> Signed-off-by: Knut Omang <knut.omang@oracle.com>
Please post as a top-level patch. Doing it like this breaks threading.
Regards,
Anthony Liguori
> ---
> hw/pc_q35.c | 1 +
> hw/ppc405_boards.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/pc_q35.c b/hw/pc_q35.c
> index 52d9976..d82353e 100644
> --- a/hw/pc_q35.c
> +++ b/hw/pc_q35.c
> @@ -214,6 +214,7 @@ static QEMUMachine pc_q35_machine = {
> .desc = "Standard PC (Q35 + ICH9, 2009)",
> .init = pc_q35_init,
> .max_cpus = 255,
> + DEFAULT_MACHINE_OPTIONS,
> };
>
> static void pc_q35_machine_init(void)
> diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c
> index 45ed376..cf371db 100644
> --- a/hw/ppc405_boards.c
> +++ b/hw/ppc405_boards.c
> @@ -362,6 +362,7 @@ static QEMUMachine ref405ep_machine = {
> .name = "ref405ep",
> .desc = "ref405ep",
> .init = ref405ep_init,
> + DEFAULT_MACHINE_OPTIONS,
> };
>
> /*****************************************************************************/
> --
> 1.7.11.7
next prev parent reply other threads:[~2013-01-16 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 8:15 [Qemu-devel] [PATCH] Add new DEFAULT_MACHINE_OPTIONS to q35 as well Knut Omang
2013-01-16 10:59 ` Markus Armbruster
2013-01-16 12:25 ` [Qemu-devel] [PATCH v2] Add new DEFAULT_MACHINE_OPTIONS to q35 and ppc405 Knut Omang
2013-01-16 13:54 ` Markus Armbruster
2013-01-16 14:53 ` Anthony Liguori [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-16 15:34 Knut Omang
2013-01-16 21:14 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq15ji1d.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=aviksil@linux.vnet.ibm.com \
--cc=knut.omang@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.