All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
	linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
	Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH 2/2] ARM: OMAP3: PM: cpuidle: optimize the clkdm idle latency in C1 state
Date: Fri, 01 Jun 2012 09:13:03 -0700	[thread overview]
Message-ID: <87pq9jt3hs.fsf@ti.com> (raw)
In-Reply-To: <CAORVsuWeHJufTA+MMg1OUNjqVdoUn0M80-atnFB5B7d4jU3eDA@mail.gmail.com> (Jean Pihet's message of "Fri, 1 Jun 2012 17:14:17 +0200")

Jean Pihet <jean.pihet@newoldbits.com> writes:

> Hi Kevin,
>
> On Thu, May 31, 2012 at 6:29 PM, Kevin Hilman <khilman@ti.com> wrote:
>> jean.pihet@newoldbits.com writes:
>>
>>> From: Jean Pihet <j-pihet@ti.com>
>>>
>>> It is not needed to iterate through all the clock domains of a
>>> power domain in order to allow or deny it to idle.
>>
>> Why?  (I know the answer, but would like it answered here.)
>>
>>> This patch allows or denies only the first registered clock domain
>>> of a power domain, and so optimizes the latency of the low power
>>> code. The functions _cpuidle_allow_idle and _cpuidle_deny_idle are
>>> not used anymore and so are removed.
>>>
>>> Signed-off-by: Jean Pihet <j-pihet@ti.com>
>>
>> Other than the changelog update, it looks good but also needs a rebase
>> like the previous patch.
>>
>> After that, I'll add them to my for_3.6/pm/performance branch and queue
>> for v3.6.
> The new series has been sent as '[PATCH 0/3] ARM: OMAP3: PM: optimize
> cpuidle C1 state latency' with the suggested changes (changelog
> updated, rebased on for_3.6/pm/performance).
>
> Note: with the code from the branch the CORE does not idle. The
> optimization changes have been tested OK though.

That's OK, I know the causes of the CORE idle retention problems and
have fixes for those queued up.

Thanks,

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2012-06-01 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 10:55 [PATCH 1/2] ARM: OMAP3: PM: cpuidle: optimize the PER latency in C1 state jean.pihet
2012-05-09 10:55 ` [PATCH 2/2] ARM: OMAP3: PM: cpuidle: optimize the clkdm idle " jean.pihet
2012-05-31 16:29   ` Kevin Hilman
2012-06-01 15:14     ` Jean Pihet
2012-06-01 16:13       ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pq9jt3hs.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=notasas@gmail.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.