From: Thomas Rast <trast@student.ethz.ch>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Lanny Ripple <lanny@spotinfluence.com>, <git@vger.kernel.org>,
Will Palmer <wmpalmer@gmail.com>
Subject: Re: Bug: rebase when an author uses accents in name on MacOSx
Date: Thu, 31 May 2012 11:33:51 +0200 [thread overview]
Message-ID: <87pq9k66f4.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <20120531011911.GC5488@sigill.intra.peff.net> (Jeff King's message of "Wed, 30 May 2012 21:19:11 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, May 30, 2012 at 04:45:33PM -0700, Junio C Hamano wrote:
>
>> Lanny Ripple <lanny@spotinfluence.com> writes:
>>
>> > lanny;~> echo "Rémi Leblond" | LANG=C LC_ALL=C sed -ne 's/.*/GIT_AUTHOR_NAME='\''&'\''/p'
>> > GIT_AUTHOR_NAME='R'émi Leblond
>>
>> So in C locale where each byte is supposed to be a single character,
>> that implementation of "sed" refuses to match a byte with high-bit
>> set when given a pattern '.'?
>>
>> That is a surprising breakage, I would have to say.
>
> It should not be too surprising, since we discussed it a few months ago:
>
> http://thread.gmane.org/gmane.comp.version-control.git/192218
>
> Thomas provided a gross but workable solution here:
>
> http://article.gmane.org/gmane.comp.version-control.git/192237
>
> and we also talked about eventually having a shell-quoting mechanism for
> pretty placeholders. Then the discussion rambled into "this sed is
> horribly broken, and the user should get a better sed" territory. Maybe
> we need to revisit that decision, since this is now two bug reports.
Three actually, also counting Will Palmer (shruggar) who brought this up
on #git-devel shortly before the thread above.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2012-05-31 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 22:16 Bug: rebase when an author uses accents in name on MacOSx Lanny Ripple
2012-05-30 23:45 ` Junio C Hamano
2012-05-30 23:57 ` Jürgen Kreileder
2012-05-31 1:19 ` Jeff King
2012-05-31 6:33 ` Junio C Hamano
2012-05-31 13:36 ` Lanny Ripple
2012-05-31 14:28 ` Thomas Rast
2012-05-31 14:56 ` Lanny Ripple
2012-05-31 17:34 ` Junio C Hamano
2012-05-31 17:49 ` Lanny Ripple
2012-05-31 18:33 ` Junio C Hamano
2012-05-31 19:21 ` Lanny Ripple
2012-06-01 9:30 ` Jeff King
2012-06-01 13:56 ` Lanny Ripple
2012-06-02 16:09 ` Jeff King
2012-06-02 16:37 ` Lanny Ripple
2012-06-01 16:19 ` Junio C Hamano
2012-06-01 17:05 ` Lanny Ripple
2012-06-01 17:57 ` Junio C Hamano
2012-06-02 16:23 ` Jeff King
2012-05-31 9:33 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq9k66f4.fsf@thomas.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lanny@spotinfluence.com \
--cc=peff@peff.net \
--cc=wmpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.