From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven Joachim Subject: Re: [PATCH 1/6] sky2: fix hang on shutdown (and other irq issues) Date: Thu, 17 Nov 2011 19:37:58 +0100 Message-ID: <87pqgqoard.fsf@turtle.gmx.de> References: <20111116234254.319625694@vyatta.com> <20111116234344.526517614@vyatta.com> <87r517w2z0.fsf@turtle.gmx.de> <20111117090104.002e110a@s6510.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain Cc: davem@davemloft.net, netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mailout-de.gmx.net ([213.165.64.23]:48604 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754203Ab1KQSiE (ORCPT ); Thu, 17 Nov 2011 13:38:04 -0500 In-Reply-To: <20111117090104.002e110a@s6510.linuxnetplumber.net> (Stephen Hemminger's message of "Thu, 17 Nov 2011 09:01:04 -0800") Sender: netdev-owner@vger.kernel.org List-ID: On 2011-11-17 18:01 +0100, Stephen Hemminger wrote: > On Thu, 17 Nov 2011 09:46:43 +0100 > Sven Joachim wrote: > >> On 2011-11-17 00:42 +0100, Stephen Hemminger wrote: >> >> > There are several problems with recent change to how IRQ's are setup. >> > * synchronize_irq in sky2_shutdown would hang because there >> > was no IRQ setup. >> > * when device was set to down, some IRQ bits left enabled so a >> > hardware error would produce IRQ with no handler >> > * quick link on Optima chip set was enabled without handler >> > * suspend/resume would leave IRQ on with no handler if device >> > was down >> >> Unfortunately, this patch does not fix the hang at shutdown for me. :-( > > You are probably stuck in some part of the code path in sky2_shutdown. Indeed. > The best debug for this is sprinkling the code printk's. That is how I > narrowed the problem down to synchronize_irq. So I found out it's hanging in napi_disable() in sky2_all_down(). Not being a kernel hacker, I don't know where to go from there. Cheers, Sven