From: Eric Anholt <eric@anholt.net>
To: Keith Packard <keithp@keithp.com>, linux-kernel@vger.kernel.org
Cc: stable@kernel.org
Subject: Re: [PATCH] drm/i915: Fix object refcount leak on mmappable size limit error path.
Date: Tue, 01 Nov 2011 09:57:27 -0700 [thread overview]
Message-ID: <87pqhb232g.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <yunsjm8pbvy.fsf@aiko.keithp.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Mon, 31 Oct 2011 23:58:25 -0700, Keith Packard <keithp@keithp.com> wrote:
Non-text part: multipart/signed
> On Mon, 31 Oct 2011 23:16:21 -0700, Eric Anholt <eric@anholt.net> wrote:
>
> > I've been seeing memory leaks on my system in the form of large
> > (300-400MB) GEM objects created by now-dead processes laying around
> > clogging up memory. I usually notice when it gets to about 1.2GB of
> > them. Hopefully this clears up the issue, but I just found this bug
> > by inspection.
> >
> > Signed-off-by: Eric Anholt <eric@anholt.net>
> > Cc: stable@kernel.org
>
> Reviewed-by: Keith Packard <keithp@keithp.com
>
> I wouldn't mind having someone audit the driver for more places where
> drm_gem_object_lookup might not be paired with drm_gem_object_unreference...
I went ahead and finished the read-through, and everything else looks
good.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-11-01 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 6:16 [PATCH] drm/i915: Fix object refcount leak on mmappable size limit error path Eric Anholt
2011-11-01 6:58 ` Keith Packard
2011-11-01 16:57 ` Eric Anholt [this message]
2011-11-01 18:29 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqhb232g.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.