From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, vishwanath.bs@ti.com
Subject: Re: [PATCH 3/3] omap2plus: cpufreq: Add SMP support to cater OMAP4430
Date: Thu, 10 Mar 2011 14:27:48 -0800 [thread overview]
Message-ID: <87pqpyhaqj.fsf@ti.com> (raw)
In-Reply-To: <1298614239-32196-4-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Fri, 25 Feb 2011 11:40:39 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On OMAP SMP configuartion, both processors share the voltage
> and clock. So both CPUs needs to be scaled together and hence
> needs software co-ordination.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> cc: Vishwanath BS <vishwanath.bs@ti.com>
[...]
> @@ -74,9 +76,13 @@ static int omap_target(struct cpufreq_policy *policy,
> unsigned int target_freq,
> unsigned int relation)
> {
> - int ret = 0;
> + int i, ret = 0;
> struct cpufreq_freqs freqs;
>
> + /* Wait untill all CPU's are initialized */
> + if (is_smp() && (num_online_cpus() < NR_CPUS))
> + return ret;
> +
Minor: the 'Wait' in the comment is a bit misleading. It should
rather say something like "Changes not allowed until all CPUs are online"
Kevin
next prev parent reply other threads:[~2011-03-10 22:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 6:10 [PATCH 0/3] [pm-wip/cpufreq] cpufreq cleanup and SMP support Santosh Shilimkar
2011-02-25 6:10 ` [PATCH 1/3] omap2plus: clock: Add an alias cpu_ck to be used in common cpufreq driver Santosh Shilimkar
2011-03-10 22:13 ` Kevin Hilman
2011-03-14 9:19 ` Santosh Shilimkar
2011-02-25 6:10 ` [PATCH 2/3] omap: cpufreq: Split omap1 and omap2plus cpufreq drivers Santosh Shilimkar
2011-02-25 7:17 ` Vishwanath Sripathy
2011-02-25 7:22 ` Santosh Shilimkar
2011-02-25 8:19 ` DebBarma, Tarun Kanti
2011-02-25 6:10 ` [PATCH 3/3] omap2plus: cpufreq: Add SMP support to cater OMAP4430 Santosh Shilimkar
2011-02-25 8:10 ` DebBarma, Tarun Kanti
2011-03-10 22:27 ` Kevin Hilman [this message]
2011-03-10 22:28 ` [PATCH 0/3] [pm-wip/cpufreq] cpufreq cleanup and SMP support Kevin Hilman
2011-03-11 5:54 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqpyhaqj.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.