Re: Latest mkfs.jffs2 is broken.

[Peter Korsgaard <jacmet@sunsite.dk>]

>>>>> "Artem" == Artem Bityutskiy <dedekind1@gmail.com> writes:

Hi,

 Artem> On Thu, 2010-10-14 at 16:54 -0500, H Hartley Sweeten wrote:

 Artem> Could you please bisect the mtd-utils.git tree and find the offending
 Artem> commit.

With big endian atleast, jffs2dump complains about invalid hdr_crc on
1.4.0, but it's working on HEAD. A bisect shows that the commit fixing
it was Mike's:

commit b864c387e8f16273aad1453d6457d847e29c3d25
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Wed Sep 22 22:32:56 2010 -0400

    mtd-utils: clean up zlib.h usage a bit
    
    Hide zlib's crc32 in compr_zlib.c and mkfs.ubifs/compr.c.
    
    jffs2reader.c and mkfs.jffs2.c don't actually use zlib, so punt the
    include from the file.
    
    mkfs.jffs2.c is implicitly using crc32 from zlib.h instead of the
    local mtd_crc32, so fix the local usage.  otherwise we get warnings
    about undefined crc32 because the file was redirecting the prototype.
    
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Hartley, that commit applies OK to 1.4.0, could you give it a try?

Artem: Time for a v1.4.1 release?

-- 
Bye, Peter Korsgaard