All of lore.kernel.org
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mioa701: fix camera regression
Date: Tue, 08 Jun 2010 19:31:58 +0200	[thread overview]
Message-ID: <87pr01mnw1.fsf@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.1006032058380.19573@axis700.grange> (Guennadi Liakhovetski's message of "Thu\, 3 Jun 2010 20\:59\:09 +0200 \(CEST\)")

> On Wed, 2 Jun 2010, Robert Jarzmik wrote:
>
>> Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the
>> camera is not working anymore.
>> 
>> After the v4l2 migration, the mt9m111 camera board
>> information was not passed to the i2c layer anymore, but
>> stored for future use of v4l2 (through soc_camera).
>> 
>> Because mioa701_i2c_devices[] was tagged as "__initdata",
>> and because after the v4l2 migration, the new structure
>> "iclink" references it, the mt9m111 driver is not probed
>> anymore, as part of "iclink" is not valid (discarded after
>> kernel init).
>> 
>> Although there is not compilation error, nor runtime oops,
>> this patch restores a working camera on the mioa701 board.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
>> 
>> --
>> Eric, could you schedule that into your fix branch please ?

Ping.

--
Robert

  reply	other threads:[~2010-06-08 17:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02 21:29 [PATCH] mioa701: fix camera regression Robert Jarzmik
2010-06-03 18:59 ` Guennadi Liakhovetski
2010-06-08 17:31   ` Robert Jarzmik [this message]
2010-06-13 10:47     ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pr01mnw1.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.