From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: linux-omap@vger.kernel.org, Shweta Gulati <shweta.gulati@ti.com>
Subject: Re: [PATCHV2] OMAP3 PM: Fix for DSP Crash at OPP 1 and 2 under DVFS+SR operation
Date: Wed, 17 Mar 2010 11:01:48 -0700 [thread overview]
Message-ID: <87pr32q12r.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1268313365-18495-1-git-send-email-vishwanath.bs@ti.com> (Vishwanath BS's message of "Thu\, 11 Mar 2010 18\:46\:05 +0530")
Vishwanath BS <vishwanath.bs@ti.com> writes:
> From: Shweta Gulati <shweta.gulati@ti.com>
>
> DSP usage at VDD1 OPP1 and OPP2 with Smartreflex enabled and any MM UCs
> running DSP codec was earlier restricted as DSP crashed.
> The root cause is wrong DPLL1/DPLL2 Bypass clock at VDD1 OPP1 and OPP2.
> The solution is to make sure DPLL1/DPLL2 bypass clock is always less than
> maximum supported frequency for the specific OPP
>
> Tested on 3630 ZOOM3.
>
> changes in V2 : Rebased to new OPP implementation
>
> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> ---
This should be broken up into two parts. One that applies to mainline
(or l-o master), and another that fixes SRF that can be applied to PM
branch. The first will be targted for mainline, but the SRF change
will be only in PM branch, as SRF is deprecated and will be replaced.
That being said, the approach in this patch is not the right approach.
It appears to completely ignore the min/max dividers that are already
managed by the clock/DPLL code.
Please add this support by modifying/extending the existing clock/DPLL
management code instead of manually writing registers.
Kevin
next prev parent reply other threads:[~2010-03-17 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 13:16 [PATCHV2] OMAP3 PM: Fix for DSP Crash at OPP 1 and 2 under DVFS+SR operation Vishwanath BS
2010-03-17 18:01 ` Kevin Hilman [this message]
2010-03-29 5:09 ` Sripathy, Vishwanath
2010-03-30 9:31 ` Paul Walmsley
2010-03-30 9:45 ` Sripathy, Vishwanath
2010-03-30 9:29 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr32q12r.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=shweta.gulati@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.