From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [Bug #14889] System wakeup by time not working anymore Date: Wed, 30 Dec 2009 18:18:14 +0900 Message-ID: <87pr5wx1k9.fsf@devron.myhome.or.jp> References: <87k4w5u1fr.fsf@devron.myhome.or.jp> <20091230095607.7229baf4@highlander.home.lan> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20091230095607.7229baf4-BhAe4JdliszF9s28bWSHhuFciLI1ps7f@public.gmane.org> ("Malte =?iso-8859-1?Q?Schr=F6der=22's?= message of "Wed, 30 Dec 2009 09:56:07 +0100") Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Malte =?iso-8859-1?Q?Schr=F6der?= Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Andrew Morton , Bjorn Helgaas , David =?iso-8859-1?Q?H=E4rdeman?= , Len Brown Malte Schr=F6der writes: > On Wed, 30 Dec 2009 02:36:56 +0900 > OGAWA Hirofumi wrote: > >> "Rafael J. Wysocki" writes: >>=20 >> > This message has been generated automatically as a part of a repor= t >> > of regressions introduced between 2.6.31 and 2.6.32. >> > >> > The following bug entry is on the current list of known regression= s >> > introduced between 2.6.31 and 2.6.32. Please verify if it still s= hould >> > be listed and let me know (either way). >> > >> > >> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=3D14889 >> > Subject : System wakeup by time not working anymore >> > Submitter : Malte Schr=F6der >> > Date : 2009-12-03 18:06 (27 days old) >> > First-Bad-Commit: http://git.kernel.org/?p=3Dlinux/kernel/git/torv= alds/linux-2.6.git;a=3Dcommit;h=3Dabd6633c67925f90775bb74755f9c547e30f1= f20 >> > References : http://marc.info/?l=3Dlinux-kernel&m=3D12598636263190= 0&w=3D4 >>=20 >> Specified commit would break the pnp driver which is using >> driver->shutdown. >>=20 >> Could you test this (untested) patch? > > I tried to reproduce the problem, it looks like it is working now :) Thanks for testing. Andrew, could you handle this pnp breakage fix? --=20 OGAWA Hirofumi [PATCH] rtc_cmos: convert shutdown to new pnp_driver->shutdown commit abd6633c67925f90775bb74755f9c547e30f1f20 adds shutdown method to bus driver blindly. With it, driver->shutdown is invalid anymore. Use pnp_driver->shutdown instead. Signed-off-by: OGAWA Hirofumi --- drivers/rtc/rtc-cmos.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff -puN drivers/rtc/rtc-cmos.c~rtc-cmos-shutdown-fix drivers/rtc/rtc-= cmos.c --- linux-2.6/drivers/rtc/rtc-cmos.c~rtc-cmos-shutdown-fix 2009-12-30 0= 1:25:10.000000000 +0900 +++ linux-2.6-hirofumi/drivers/rtc/rtc-cmos.c 2009-12-30 01:27:36.00000= 0000 +0900 @@ -1096,9 +1096,9 @@ static int cmos_pnp_resume(struct pnp_de #define cmos_pnp_resume NULL #endif =20 -static void cmos_pnp_shutdown(struct device *pdev) +static void cmos_pnp_shutdown(struct pnp_dev *pnp) { - if (system_state =3D=3D SYSTEM_POWER_OFF && !cmos_poweroff(pdev)) + if (system_state =3D=3D SYSTEM_POWER_OFF && !cmos_poweroff(&pnp->dev)= ) return; =20 cmos_do_shutdown(); @@ -1117,15 +1117,12 @@ static struct pnp_driver cmos_pnp_driver .id_table =3D rtc_ids, .probe =3D cmos_pnp_probe, .remove =3D __exit_p(cmos_pnp_remove), + .shutdown =3D cmos_pnp_shutdown, =20 /* flag ensures resume() gets called, and stops syslog spam */ .flags =3D PNP_DRIVER_RES_DO_NOT_CHANGE, .suspend =3D cmos_pnp_suspend, .resume =3D cmos_pnp_resume, - .driver =3D { - .name =3D (char *)driver_name, - .shutdown =3D cmos_pnp_shutdown, - } }; =20 #endif /* CONFIG_PNP */ _ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbZL3JSb (ORCPT ); Wed, 30 Dec 2009 04:18:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751797AbZL3JS1 (ORCPT ); Wed, 30 Dec 2009 04:18:27 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:38140 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbZL3JSX (ORCPT ); Wed, 30 Dec 2009 04:18:23 -0500 From: OGAWA Hirofumi To: Malte =?iso-8859-1?Q?Schr=F6der?= Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , "Andrew Morton" , "Bjorn Helgaas" , David =?iso-8859-1?Q?H=E4rdeman?= , "Len Brown" Subject: Re: [Bug #14889] System wakeup by time not working anymore References: <87k4w5u1fr.fsf@devron.myhome.or.jp> <20091230095607.7229baf4@highlander.home.lan> Date: Wed, 30 Dec 2009 18:18:14 +0900 In-Reply-To: <20091230095607.7229baf4@highlander.home.lan> ("Malte =?iso-8859-1?Q?Schr=F6der=22's?= message of "Wed, 30 Dec 2009 09:56:07 +0100") Message-ID: <87pr5wx1k9.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Malte Schröder writes: > On Wed, 30 Dec 2009 02:36:56 +0900 > OGAWA Hirofumi wrote: > >> "Rafael J. Wysocki" writes: >> >> > This message has been generated automatically as a part of a report >> > of regressions introduced between 2.6.31 and 2.6.32. >> > >> > The following bug entry is on the current list of known regressions >> > introduced between 2.6.31 and 2.6.32. Please verify if it still should >> > be listed and let me know (either way). >> > >> > >> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14889 >> > Subject : System wakeup by time not working anymore >> > Submitter : Malte Schröder >> > Date : 2009-12-03 18:06 (27 days old) >> > First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=abd6633c67925f90775bb74755f9c547e30f1f20 >> > References : http://marc.info/?l=linux-kernel&m=125986362631900&w=4 >> >> Specified commit would break the pnp driver which is using >> driver->shutdown. >> >> Could you test this (untested) patch? > > I tried to reproduce the problem, it looks like it is working now :) Thanks for testing. Andrew, could you handle this pnp breakage fix? -- OGAWA Hirofumi [PATCH] rtc_cmos: convert shutdown to new pnp_driver->shutdown commit abd6633c67925f90775bb74755f9c547e30f1f20 adds shutdown method to bus driver blindly. With it, driver->shutdown is invalid anymore. Use pnp_driver->shutdown instead. Signed-off-by: OGAWA Hirofumi --- drivers/rtc/rtc-cmos.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff -puN drivers/rtc/rtc-cmos.c~rtc-cmos-shutdown-fix drivers/rtc/rtc-cmos.c --- linux-2.6/drivers/rtc/rtc-cmos.c~rtc-cmos-shutdown-fix 2009-12-30 01:25:10.000000000 +0900 +++ linux-2.6-hirofumi/drivers/rtc/rtc-cmos.c 2009-12-30 01:27:36.000000000 +0900 @@ -1096,9 +1096,9 @@ static int cmos_pnp_resume(struct pnp_de #define cmos_pnp_resume NULL #endif -static void cmos_pnp_shutdown(struct device *pdev) +static void cmos_pnp_shutdown(struct pnp_dev *pnp) { - if (system_state == SYSTEM_POWER_OFF && !cmos_poweroff(pdev)) + if (system_state == SYSTEM_POWER_OFF && !cmos_poweroff(&pnp->dev)) return; cmos_do_shutdown(); @@ -1117,15 +1117,12 @@ static struct pnp_driver cmos_pnp_driver .id_table = rtc_ids, .probe = cmos_pnp_probe, .remove = __exit_p(cmos_pnp_remove), + .shutdown = cmos_pnp_shutdown, /* flag ensures resume() gets called, and stops syslog spam */ .flags = PNP_DRIVER_RES_DO_NOT_CHANGE, .suspend = cmos_pnp_suspend, .resume = cmos_pnp_resume, - .driver = { - .name = (char *)driver_name, - .shutdown = cmos_pnp_shutdown, - } }; #endif /* CONFIG_PNP */ _