All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH, REGRESSION] mpc83xx: provide option to set LCRR early
Date: Fri, 27 Nov 2009 10:06:43 +0100	[thread overview]
Message-ID: <87pr7472vw.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1258717363-19554-1-git-send-email-jacmet@sunsite.dk> (Peter Korsgaard's message of "Fri\, 20 Nov 2009 12\:42\:43 +0100")

>>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:

 Peter> Commit c7190f02 (retain POR values of non-configured ACR, SPCR, SCCR,
 Peter> and LCRR bitfields) moved the LCRR assignment to after relocation
 Peter> to RAM because of the potential problem with changing the local bus
 Peter> clock while executing from flash.

Comments?

 Peter> For some boards this isn't needed (E.G. when running from a normal async
 Peter> NOR flash), and running all code up to cpu_init_r at the slow bootup
 Peter> speed adversively affects the startup time.

 Peter> E.G. on a 8347 board a bootup time increase of ~600ms has been observed:

 Peter>    0.020 CPU:   e300c1, MPC8347_PBGA_EA, Rev: 3.0 at 400 MHz, CSB: 266.667 MHz
 Peter>    0.168 RS:    232
 Peter>    0.172 I2C:   ready
 Peter>    0.176 DRAM:  64 MB
 Peter>    1.236 FLASH: 32 MB

 Peter> Versus:

 Peter>    0.016 CPU:   e300c1, MPC8347_PBGA_EA, Rev: 3.0 at 400 MHz, CSB: 266.667 MHz
 Peter>    0.092 RS:    232
 Peter>    0.092 I2C:   ready
 Peter>    0.096 DRAM:  64 MB
 Peter>    0.644 FLASH: 32 MB

 Peter> Fix it by introducing CONFIG_SYS_LCRR_EARLY, and set LCRR in cpu_init_f
 Peter> instead of in cpu_init_r if set.

 Peter> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
 Peter> ---
 Peter>  cpu/mpc83xx/cpu_init.c |   35 +++++++++++++++++++++++++++++++++++
 Peter>  1 files changed, 35 insertions(+), 0 deletions(-)

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-11-27  9:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 11:42 [U-Boot] [PATCH, REGRESSION] mpc83xx: provide option to set LCRR early Peter Korsgaard
2009-11-27  9:06 ` Peter Korsgaard [this message]
2009-12-05  0:29   ` Wolfgang Denk
2009-12-05  0:51     ` Kim Phillips
2009-12-05  0:52       ` Wolfgang Denk
2009-12-05  2:30 ` Kim Phillips
2009-12-05 20:27   ` Peter Korsgaard
2009-12-07 17:12     ` Kim Phillips
2009-12-07 21:10       ` Peter Korsgaard
2009-12-07 21:38         ` Kim Phillips
2009-12-07 21:46           ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pr7472vw.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.