From: Andi Kleen <andi@firstfloor.org>
To: "Liuweni" <qingshenlwy@gmail.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"strongzgy" <strongzgy@gmail.com>, "xgr178" <xgr178@163.com>,
"Liu Hui" <onlyflyer@gmail.com>, "viro" <viro@zeniv.linux.org.uk>,
"akpm" <akpm@linux-foundation.org>, "jack" <jack@suse.cz>,
"npiggin" <npiggin@suse.de>,
"linux-fsdevel" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/3]fs/inode: iunique() Optimize Performance
Date: Wed, 25 Nov 2009 16:06:22 +0100 [thread overview]
Message-ID: <87pr76ve35.fsf@basil.nowhere.org> (raw)
In-Reply-To: <200911252209432039291@gmail.com> (Liuweni's message of "Wed, 25 Nov 2009 22:09:45 +0800")
"Liuweni" <qingshenlwy@gmail.com> writes:
> ---
> move the if condition out the while{}.
> While the function executing, the if
> condition won't check again and again.
> And this code won't change the function
> of iunique().
Normally compiler automatically move loop invariant code out of loop
bodies. Have you verified that's not the case here?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2009-11-25 15:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 14:09 [PATCH 1/3]fs/inode: iunique() Optimize Performance Liuweni
2009-11-25 14:15 ` Matthew Wilcox
2009-11-25 19:20 ` Jérémy Cochoy
2009-11-25 19:52 ` Matthew Wilcox
2009-12-01 5:01 ` liu weni
2009-12-01 5:01 ` liu weni
2009-12-01 12:03 ` Matthew Wilcox
2009-12-01 13:21 ` Liuweni
2009-12-01 13:21 ` Liuweni
2009-12-01 14:00 ` Matthew Wilcox
2009-12-02 9:42 ` Nick Piggin
2009-11-25 14:51 ` Liuweni
2009-11-25 14:51 ` Liuweni
2009-11-25 14:54 ` Matthew Wilcox
2009-11-25 15:06 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr76ve35.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=onlyflyer@gmail.com \
--cc=qingshenlwy@gmail.com \
--cc=strongzgy@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xgr178@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.