From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtLM8-0006Yd-Tz
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:06:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtLM4-0006US-71
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:06:00 -0400
Received: from [199.232.76.173] (port=33964 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtLM3-0006UK-Tm
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:05:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33605)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MtLM3-00024R-Bj
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:05:55 -0400
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/omap_dma: add matching {} in if 0
References: <cover.1254376223.git.mst@redhat.com>
	<20091001055144.GC5068@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 01 Oct 2009 15:05:49 +0200
In-Reply-To: <20091001055144.GC5068@redhat.com> (Michael S. Tsirkin's message
	of "Thu\, 1 Oct 2009 07\:51\:44 +0200")
Message-ID: <87pr976z82.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> writes:

> MULTI_REQ is never defined, so it doesn't matter much, but since we have
> an if statement there, let's add {} to clarify what it should do if it's
> uncommented.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/omap_dma.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/hw/omap_dma.c b/hw/omap_dma.c
> index 205d010..ab5e925 100644
> --- a/hw/omap_dma.c
> +++ b/hw/omap_dma.c
> @@ -588,7 +588,7 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma)
>  #ifdef MULTI_REQ
>      /* TODO: should all of this only be done if dma->update, and otherwise
>       * inside omap_dma_transfer_generic below - check what's faster.  */
> -    if (dma->update)
> +    if (dma->update) {
>  #endif
>  
>      /* If the channel is element synchronized, deactivate it */
> @@ -670,6 +670,8 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma)
>           * bits on it.  */
>  #ifndef MULTI_REQ
>      }
> +#else
> +    }
>  #endif
>  
>      omap_dma_interrupts_update(s);

Doesn't this look silly?  Just close the brace :)