From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqpDW-0000BF-Gv
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 10:22:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqpDS-0000AV-4M
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 10:22:42 -0400
Received: from [199.232.76.173] (port=46668 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqpDR-0000AS-Op
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 10:22:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29056)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MqpDR-0004XQ-6t
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 10:22:37 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8OEMaGl003278
	for <qemu-devel@nongnu.org>; Thu, 24 Sep 2009 10:22:36 -0400
Subject: Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of
	silently exiting
References: <1253704471-30740-1-git-send-email-amit.shah@redhat.com>
	<8763b97588.fsf@pike.pond.sub.org>
	<20090924035908.GA4584@amit-x200.redhat.com>
	<87my4kqxl8.fsf@pike.pond.sub.org>
	<20090924133144.GA19389@amit-x200.redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 24 Sep 2009 16:22:34 +0200
In-Reply-To: <20090924133144.GA19389@amit-x200.redhat.com> (Amit Shah's
	message of "Thu\, 24 Sep 2009 19\:01\:44 +0530")
Message-ID: <87pr9gpglx.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

Amit Shah <amit.shah@redhat.com> writes:

> On (Thu) Sep 24 2009 [15:30:27], Markus Armbruster wrote:
>> Amit Shah <amit.shah@redhat.com> writes:
>> 
>> > Hey Markus,
>> >
>> > On (Wed) Sep 23 2009 [22:53:27], Markus Armbruster wrote:
>> >> Amit Shah <amit.shah@redhat.com> writes:
>> >> 
>> >> > If initializing a device fails, show the name of the device
>> >> > and then exit
>> >> 
>> >> "and then exit" is misleading, as you don't add an exit.
>> >
>> > The 'return NULL' does that -- the calling function exits.
>> > (doesn't the subject line clarify that?)
>> 
>> You could say "show the name of the device before exiting".
>
> That's what the subject says! :-)
>
>> The message as you worded it made me look for an exit where there wasn't
>> one before.
>
> I'll respin it nevertheless.
>
> 		Amit

Thanks, and hope you don't mind me being such a stickler for clear
commit messages.