From: Andi Kleen <andi@firstfloor.org>
To: Sage Weil <sage@newdream.net>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
Neil Brown <neilb@suse.de>,
stable@kernel.org
Subject: Re: [PATCH] md: avoid use of broken kzalloc mempool
Date: Mon, 03 Aug 2009 23:13:46 +0200 [thread overview]
Message-ID: <87prbcr46t.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1249332888-13440-1-git-send-email-sage@newdream.net> (Sage Weil's message of "Mon, 3 Aug 2009 13:54:46 -0700")
Sage Weil <sage@newdream.net> writes:
> The kzalloc mempool does not re-zero items that have been used and then
> returned to the pool. Manually zero the allocated multipath_bh instead.
Why not fix that in mempool instead? That would seem like the right place
to fix such a bug, instead of adding workarounds to all callers.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Sage Weil <sage@newdream.net>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
Neil Brown <neilb@suse.de>, <stable@kernel.org>
Subject: Re: [PATCH] md: avoid use of broken kzalloc mempool
Date: Mon, 03 Aug 2009 23:13:46 +0200 [thread overview]
Message-ID: <87prbcr46t.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1249332888-13440-1-git-send-email-sage@newdream.net> (Sage Weil's message of "Mon, 3 Aug 2009 13:54:46 -0700")
Sage Weil <sage@newdream.net> writes:
> The kzalloc mempool does not re-zero items that have been used and then
> returned to the pool. Manually zero the allocated multipath_bh instead.
Why not fix that in mempool instead? That would seem like the right place
to fix such a bug, instead of adding workarounds to all callers.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-08-03 21:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 20:54 [PATCH] md: avoid use of broken kzalloc mempool Sage Weil
2009-08-03 20:54 ` Sage Weil
2009-08-03 20:54 ` [PATCH] ibmvscsi: avoid unnecessary use of kzalloc_pool Sage Weil
2009-08-03 20:54 ` [PATCH] mm: remove broken 'kzalloc' mempool Sage Weil
2009-08-03 20:54 ` Sage Weil
2009-08-03 20:57 ` Sage Weil
2009-08-03 20:57 ` Sage Weil
2009-08-03 21:19 ` [PATCH] ibmvscsi: avoid unnecessary use of kzalloc_pool Brian King
2009-08-03 21:13 ` Andi Kleen [this message]
2009-08-03 21:13 ` [PATCH] md: avoid use of broken kzalloc mempool Andi Kleen
2009-08-03 21:29 ` Sage Weil
2009-08-03 22:03 ` NeilBrown
2009-08-03 22:03 ` NeilBrown
2009-08-11 21:52 ` Andrew Morton
2009-08-11 22:03 ` Sage Weil
2009-08-12 23:17 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prbcr46t.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sage@newdream.net \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.