All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Brian Haley <brian.haley-VXdhtT5mjnY@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Alexey Dobriyan
	<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/2] c/r: Add AF_INET support (v3)
Date: Tue, 07 Jul 2009 18:31:32 -0700	[thread overview]
Message-ID: <87prccq7t7.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <4A53F50D.30001-VXdhtT5mjnY@public.gmane.org> (Brian Haley's message of "Tue\, 07 Jul 2009 21\:23\:25 -0400")

Hi Brian,

>> +	struct {
>> +		char saddr[16];
>> +		char rcv_saddr[16];
>> +		char daddr[16];
>> +	} inet6 __attribute__ ((aligned(8)));

BH> These should be 'struct in6_addr'.

Okay.

BH> And just like in your IPv4 section you need a FIXME here for the
BH> things you skipped :)

Heh, okay :)

BH> There's an inline called ipv6_addr_copy() that will do the same
BH> thing, then you could drop the alen argument.

Okay, cool.

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

  parent reply	other threads:[~2009-07-08  1:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 19:26 [RFC] Add Checkpoint/Restart support for UNIX and INET sockets Dan Smith
     [not found] ` <1246994776-1882-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-07-07 19:26   ` [PATCH 1/2] c/r: Add AF_UNIX support (v5) Dan Smith
     [not found]     ` <1246994776-1882-2-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-07-08  6:32       ` Oren Laadan
2009-07-08 14:01         ` Serge E. Hallyn
2009-07-08 19:27           ` Dan Smith
2009-07-08 22:01             ` Serge E. Hallyn
     [not found]         ` <4A543D82.5080408-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-07-08 15:23           ` Dan Smith
2009-07-08 16:44             ` Oren Laadan
     [not found]               ` <4A54CCDB.1090602-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-07-08 16:55                 ` Dan Smith
2009-07-08 18:16                   ` Oren Laadan
2009-07-07 19:26   ` [PATCH 2/2] c/r: Add AF_INET support (v3) Dan Smith
2009-07-08  1:23     ` Brian Haley
     [not found]       ` <4A53F50D.30001-VXdhtT5mjnY@public.gmane.org>
2009-07-08  1:31         ` Dan Smith [this message]
2009-07-08 13:58     ` Oren Laadan
2009-07-08 15:30       ` Dan Smith
2009-07-13 19:02     ` John Dykstra
2009-07-13 19:10       ` Dan Smith
2009-07-24 20:44     ` John Dykstra
2009-07-28 17:22       ` Oren Laadan
2009-07-25 21:02     ` John Dykstra
2009-07-28 16:00       ` Dan Smith
2009-07-28 17:07         ` Oren Laadan
     [not found]           ` <4A6F306A.40303-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-07-29 22:10             ` John Dykstra
2009-07-29  0:28         ` John Dykstra
2009-07-31 19:35     ` John Dykstra
2009-07-31 19:40       ` Dan Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87prccq7t7.fsf@caffeine.danplanet.com \
    --to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=brian.haley-VXdhtT5mjnY@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.