From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] [draft] add lvconvert --repair --auto that honours lvm.conf mirror policy
Date: Sat, 23 May 2009 11:34:23 +0200 [thread overview]
Message-ID: <87pre040yo.fsf@mornfall.net> (raw)
In-Reply-To: <873aaybhzz.fsf@mornfall.net> (Petr Rockai's message of "Thu, 21 May 2009 17:20:00 +0200")
Hi again,
I have now tested the patch, and following is (obviously) also needed to make
it work. Other than that, everything seems to work as expected (most
importantly, the mirror_device_fault_policy is obeyed by dmeventd).
The missing patch bit:
===================================================================
RCS file: /cvs/lvm2/LVM2/tools/commands.h,v
retrieving revision 1.125
diff -u -p -r1.125 commands.h
--- tools/commands.h 25 Apr 2009 01:18:00 -0000 1.125
+++ tools/commands.h 23 May 2009 09:31:29 -0000
@@ -94,7 +94,7 @@ xx(lvconvert,
0,
"lvconvert "
"[-m|--mirrors Mirrors [{--mirrorlog {disk|core}|--corelog}]]\n"
- "\t[--repair]\n"
+ "\t[--repair [--auto]]\n"
"\t[-R|--regionsize MirrorLogRegionSize]\n"
"\t[--alloc AllocationPolicy]\n"
"\t[-b|--background]\n"
@@ -116,8 +116,8 @@ xx(lvconvert,
"\tOriginalLogicalVolume[Path] SnapshotLogicalVolume[Path]\n",
alloc_ARG, background_ARG, chunksize_ARG, corelog_ARG, interval_ARG,
- mirrorlog_ARG, mirrors_ARG, regionsize_ARG, repair_ARG, snapshot_ARG,
- test_ARG, zero_ARG)
+ mirrorlog_ARG, mirrors_ARG, regionsize_ARG, repair_ARG, auto_ARG,
+ snapshot_ARG, test_ARG, zero_ARG)
xx(lvcreate,
"Create a logical volume",
Is this version OK to commit, then? (Better option names than --repair --auto
are still solicited, but probably not such a high priority anyway...)
Yours,
Petr.
--
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentation
next prev parent reply other threads:[~2009-05-23 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 15:20 [PATCH] [draft] add lvconvert --repair --auto that honours lvm.conf mirror policy Petr Rockai
2009-05-21 15:27 ` Jonathan Brassow
2009-05-23 9:34 ` Petr Rockai [this message]
2009-06-02 18:51 ` [PATCH] lvconvert --repair prompts and policies Petr Rockai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pre040yo.fsf@mornfall.net \
--to=prockai@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.