From: Robert Jarzmik <robert.jarzmik@free.fr>
To: broonie@opensource.wolfsonmicro.com
Cc: alsa-devel@alsa-project.org, eric.miao@marvell.com,
linux-arm-kernel@lists.arm.linux.org.uk,
Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH] pxa2xx-ac97: fix reset gpio mode setting
Date: Mon, 11 May 2009 19:30:14 +0200 [thread overview]
Message-ID: <87prefeee1.fsf@free.fr> (raw)
In-Reply-To: <f17812d70905110351w6b5250fcqd19590afbc42011e@mail.gmail.com> (Eric Miao's message of "Mon\, 11 May 2009 18\:51\:14 +0800")
Eric Miao <eric.y.miao@gmail.com> writes:
> On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport <mike@compulab.co.il> wrote:
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>
> Acked-by: Eric Miao <eric.miao@marvell.com>
Argh, that was my screw up ... Let's forward that to Mark, and see if that can
make it into the 2.6.30 fixes.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Robert
> Just curious, this didn't cause any issue in the past :)
>
>> ---
>> sound/arm/pxa2xx-ac97-lib.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
>> index a2c12d1..6fdca97 100644
>> --- a/sound/arm/pxa2xx-ac97-lib.c
>> +++ b/sound/arm/pxa2xx-ac97-lib.c
>> @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action)
>> switch (resetgpio_action) {
>> case RESETGPIO_NORMAL_ALTFUNC:
>> if (reset_gpio == 113)
>> - mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
>> + mode = 113 | GPIO_ALT_FN_2_OUT;
>> if (reset_gpio == 95)
>> mode = 95 | GPIO_ALT_FN_1_OUT;
>> break;
>> --
>> 1.5.6.4
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>
>
>
>
> --
> Cheers
> - eric
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2009-05-11 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 10:11 [PATCH] pxa2xx-ac97: fix reset gpio mode setting Mike Rapoport
2009-05-11 10:51 ` Eric Miao
2009-05-11 11:08 ` Mike Rapoport
2009-05-11 13:15 ` [alsa-devel] " Tomas 'Sleep_Walker' Cech
2009-05-11 17:30 ` Robert Jarzmik [this message]
2009-05-11 18:04 ` Mark Brown
2009-05-12 2:32 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prefeee1.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.miao@marvell.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.