* [PATCH] pxa2xx-ac97: fix reset gpio mode setting
@ 2009-05-11 10:11 Mike Rapoport
2009-05-11 10:51 ` Eric Miao
2009-05-11 18:04 ` Mark Brown
0 siblings, 2 replies; 7+ messages in thread
From: Mike Rapoport @ 2009-05-11 10:11 UTC (permalink / raw)
To: eric.miao; +Cc: alsa-devel, linux-arm-kernel, Mike Rapoport
Signed-off-by: Mike Rapoport <mike@compulab.co.il>
---
sound/arm/pxa2xx-ac97-lib.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
index a2c12d1..6fdca97 100644
--- a/sound/arm/pxa2xx-ac97-lib.c
+++ b/sound/arm/pxa2xx-ac97-lib.c
@@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action)
switch (resetgpio_action) {
case RESETGPIO_NORMAL_ALTFUNC:
if (reset_gpio == 113)
- mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
+ mode = 113 | GPIO_ALT_FN_2_OUT;
if (reset_gpio == 95)
mode = 95 | GPIO_ALT_FN_1_OUT;
break;
--
1.5.6.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] pxa2xx-ac97: fix reset gpio mode setting
2009-05-11 10:11 [PATCH] pxa2xx-ac97: fix reset gpio mode setting Mike Rapoport
@ 2009-05-11 10:51 ` Eric Miao
2009-05-11 11:08 ` Mike Rapoport
` (2 more replies)
2009-05-11 18:04 ` Mark Brown
1 sibling, 3 replies; 7+ messages in thread
From: Eric Miao @ 2009-05-11 10:51 UTC (permalink / raw)
To: Mike Rapoport; +Cc: alsa-devel, eric.miao, linux-arm-kernel
On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport <mike@compulab.co.il> wrote:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
Acked-by: Eric Miao <eric.miao@marvell.com>
Just curious, this didn't cause any issue in the past :)
> ---
> sound/arm/pxa2xx-ac97-lib.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
> index a2c12d1..6fdca97 100644
> --- a/sound/arm/pxa2xx-ac97-lib.c
> +++ b/sound/arm/pxa2xx-ac97-lib.c
> @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action)
> switch (resetgpio_action) {
> case RESETGPIO_NORMAL_ALTFUNC:
> if (reset_gpio == 113)
> - mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
> + mode = 113 | GPIO_ALT_FN_2_OUT;
> if (reset_gpio == 95)
> mode = 95 | GPIO_ALT_FN_1_OUT;
> break;
> --
> 1.5.6.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
Cheers
- eric
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pxa2xx-ac97: fix reset gpio mode setting
2009-05-11 10:51 ` Eric Miao
@ 2009-05-11 11:08 ` Mike Rapoport
2009-05-11 13:15 ` [alsa-devel] " Tomas 'Sleep_Walker' Cech
2009-05-11 17:30 ` Robert Jarzmik
2 siblings, 0 replies; 7+ messages in thread
From: Mike Rapoport @ 2009-05-11 11:08 UTC (permalink / raw)
To: Eric Miao; +Cc: alsa-devel, eric.miao, linux-arm-kernel
Eric Miao wrote:
> On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport <mike@compulab.co.il> wrote:
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>
> Acked-by: Eric Miao <eric.miao@marvell.com>
>
> Just curious, this didn't cause any issue in the past :)
It's 2.6.30 material so there's not much past :)
>> ---
>> sound/arm/pxa2xx-ac97-lib.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
>> index a2c12d1..6fdca97 100644
>> --- a/sound/arm/pxa2xx-ac97-lib.c
>> +++ b/sound/arm/pxa2xx-ac97-lib.c
>> @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action)
>> switch (resetgpio_action) {
>> case RESETGPIO_NORMAL_ALTFUNC:
>> if (reset_gpio == 113)
>> - mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
>> + mode = 113 | GPIO_ALT_FN_2_OUT;
>> if (reset_gpio == 95)
>> mode = 95 | GPIO_ALT_FN_1_OUT;
>> break;
>> --
>> 1.5.6.4
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>
>
>
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH] pxa2xx-ac97: fix reset gpio mode setting
2009-05-11 10:51 ` Eric Miao
2009-05-11 11:08 ` Mike Rapoport
@ 2009-05-11 13:15 ` Tomas 'Sleep_Walker' Cech
2009-05-11 17:30 ` Robert Jarzmik
2 siblings, 0 replies; 7+ messages in thread
From: Tomas 'Sleep_Walker' Cech @ 2009-05-11 13:15 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Eric Miao, Mike Rapoport, eric.miao, alsa-devel
Dne pondělí 11 Květen 2009 12:51:14 Eric Miao napsal(a):
> On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport <mike@compulab.co.il> wrote:
> > Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>
> Acked-by: Eric Miao <eric.miao@marvell.com>
>
> Just curious, this didn't cause any issue in the past :)
>
It's probably because all machines set AFN with pxa2xx_mfp_config in start-up.
I have seen this when I tried to locate Palm AC97 problem after resume...
Tomas Cech
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pxa2xx-ac97: fix reset gpio mode setting
2009-05-11 10:51 ` Eric Miao
2009-05-11 11:08 ` Mike Rapoport
2009-05-11 13:15 ` [alsa-devel] " Tomas 'Sleep_Walker' Cech
@ 2009-05-11 17:30 ` Robert Jarzmik
2 siblings, 0 replies; 7+ messages in thread
From: Robert Jarzmik @ 2009-05-11 17:30 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, eric.miao, linux-arm-kernel, Mike Rapoport
Eric Miao <eric.y.miao@gmail.com> writes:
> On Mon, May 11, 2009 at 6:11 PM, Mike Rapoport <mike@compulab.co.il> wrote:
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>
> Acked-by: Eric Miao <eric.miao@marvell.com>
Argh, that was my screw up ... Let's forward that to Mark, and see if that can
make it into the 2.6.30 fixes.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Robert
> Just curious, this didn't cause any issue in the past :)
>
>> ---
>> sound/arm/pxa2xx-ac97-lib.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
>> index a2c12d1..6fdca97 100644
>> --- a/sound/arm/pxa2xx-ac97-lib.c
>> +++ b/sound/arm/pxa2xx-ac97-lib.c
>> @@ -65,7 +65,7 @@ static void set_resetgpio_mode(int resetgpio_action)
>> switch (resetgpio_action) {
>> case RESETGPIO_NORMAL_ALTFUNC:
>> if (reset_gpio == 113)
>> - mode = 113 | GPIO_OUT | GPIO_DFLT_LOW;
>> + mode = 113 | GPIO_ALT_FN_2_OUT;
>> if (reset_gpio == 95)
>> mode = 95 | GPIO_ALT_FN_1_OUT;
>> break;
>> --
>> 1.5.6.4
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>
>
>
>
> --
> Cheers
> - eric
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pxa2xx-ac97: fix reset gpio mode setting
2009-05-11 10:11 [PATCH] pxa2xx-ac97: fix reset gpio mode setting Mike Rapoport
2009-05-11 10:51 ` Eric Miao
@ 2009-05-11 18:04 ` Mark Brown
2009-05-12 2:32 ` Eric Miao
1 sibling, 1 reply; 7+ messages in thread
From: Mark Brown @ 2009-05-11 18:04 UTC (permalink / raw)
To: Mike Rapoport; +Cc: alsa-devel, eric.miao, linux-arm-kernel
On Mon, May 11, 2009 at 01:11:38PM +0300, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
Applied, thanks. Please CC me on things...
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pxa2xx-ac97: fix reset gpio mode setting
2009-05-11 18:04 ` Mark Brown
@ 2009-05-12 2:32 ` Eric Miao
0 siblings, 0 replies; 7+ messages in thread
From: Eric Miao @ 2009-05-12 2:32 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, eric.miao, linux-arm-kernel, Mike Rapoport
On Tue, May 12, 2009 at 2:04 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, May 11, 2009 at 01:11:38PM +0300, Mike Rapoport wrote:
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>
> Applied, thanks. Please CC me on things...
My fault, I forgot to include you, sorry about that.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-05-12 2:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-11 10:11 [PATCH] pxa2xx-ac97: fix reset gpio mode setting Mike Rapoport
2009-05-11 10:51 ` Eric Miao
2009-05-11 11:08 ` Mike Rapoport
2009-05-11 13:15 ` [alsa-devel] " Tomas 'Sleep_Walker' Cech
2009-05-11 17:30 ` Robert Jarzmik
2009-05-11 18:04 ` Mark Brown
2009-05-12 2:32 ` Eric Miao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.