From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KKdz2-0002cB-Hn for mharc-grub-devel@gnu.org; Sun, 20 Jul 2008 14:50:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKdz0-0002c4-Is for grub-devel@gnu.org; Sun, 20 Jul 2008 14:50:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKdyz-0002br-Ew for grub-devel@gnu.org; Sun, 20 Jul 2008 14:50:09 -0400 Received: from [199.232.76.173] (port=36532 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKdyz-0002bo-A7 for grub-devel@gnu.org; Sun, 20 Jul 2008 14:50:09 -0400 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]:2576) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KKdyy-0002bA-Sf for grub-devel@gnu.org; Sun, 20 Jul 2008 14:50:09 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id m6KIo7ek063325 for ; Sun, 20 Jul 2008 20:50:08 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080702001046.7554.37059.stgit@dv.roinet.com> <87tzf66d6w.fsf@xs4all.nl> <1215110887.4585.35.camel@dv> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 20 Jul 2008 20:50:54 +0200 In-Reply-To: <1215110887.4585.35.camel@dv> (Pavel Roskin's message of "Thu, 03 Jul 2008 14:48:07 -0400") Message-ID: <87prp8ie41.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Fix warning in fs/xfs.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2008 18:50:10 -0000 Pavel Roskin writes: > On Thu, 2008-07-03 at 20:21 +0200, Marco Gerards wrote: >> Pavel Roskin writes: >> >> > ChangeLog: >> > * fs/xfs.c (struct grub_xfs_dir_header): Use names similar to >> > those in Linux XFS code. Provide a way to access 64-bit parent >> > inode. >> > (grub_xfs_iterate_dir): Use the new names. Avoid reading past >> > the end of struct grub_xfs_dir_header. >> >> *please* do not look at Linux code or whatever *and* contribute to >> GRUB. It might cause copyright troubles I will have to deal with :-/ > > I just tried to make names similar without copying any code. But it's a > useful reminder. What I meant is that even *looking* at code might cause problems. People can claim you have stolen their ideas. That would essentially mean the same as copying code. I just want to avoid such problems at beforehand. >> I do not see the advantage of this patch. Can you please explain why >> we need these name changes? > > We were casting a pointer to a 32-bit integer to a pointer to a 64-bit > integer, which is bad, and gcc was emitting a warning about it. Right > Worse yet, the 64-bit value was "sticking" beyond the end the structure > we were using to describe the header. > > i4 and i8 are generally used by Linux XFS code to describe 32-bit and > 64-bit values if either can be used. The "smallino" field was highly > misleading because it had to be negated. It's the number of "big" (i8 > or 64-bit) entries. If it's 0, then the entries are "small". > > So it was natural to call it "i8count". And once it was "i8count", it > was natural to call the first value "count". > > If you prefer another naming convention, let's rename the entries > according to it. I was thinking having 2 32-bit integers "parent_hi" > and "parent_lo" or something like that. Anyway, let's not use > "smallino" - "bigentries" would be better. What I suggest is that you pick the names yourself or from a standard, instead of from Linux code. -- Marco