From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org,
akpm@linux-foundation.org, riel@redhat.com
Subject: Re: [PATCH 2/8] slub: Replace ctor field with ops field in /sys/slab/*
Date: Sun, 20 Jul 2008 02:47:56 +0900 [thread overview]
Message-ID: <87prp9lq9f.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <87tzellqf9.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Sun, 20 Jul 2008 02:44:26 +0900")
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Pekka J Enberg <penberg@cs.helsinki.fi> writes:
>
>> + if (s->ctor) {
>> + x += sprintf(buf + x, "ctor : ");
>> + x += sprint_symbol(buf + x, (unsigned long)s->ctor);
>> + x += sprintf(buf + x, "\n");
>
> How about new "%pS" like following for it? If CONFIG_KALLSYMS=n, it has
> difference though...
>
> x += sprintf(buf + x, "ctor : %pS\n", (unsigned long)s->ctor);
Oops, it should be pointer.
x += sprintf(buf + x, "ctor : %pS\n", s->ctor);
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2008-07-19 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 12:30 [PATCH 2/8] slub: Replace ctor field with ops field in /sys/slab/* Pekka J Enberg
2008-07-19 17:44 ` OGAWA Hirofumi
2008-07-19 17:47 ` OGAWA Hirofumi [this message]
2008-07-21 9:08 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prp9lq9f.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.