All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package:  gperf
Date: Wed, 09 Jul 2008 09:14:03 +0200	[thread overview]
Message-ID: <87prpn5y2s.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080709042746.AE27F3C6A2@busybox.net> (ulf@uclibc.org's message of "Tue\, 8 Jul 2008 21\:27\:46 -0700 \(PDT\)")

>>>>> "ulf" == ulf  <ulf@uclibc.org> writes:

 ulf> Author: ulf
 ulf> Date: 2008-07-08 21:27:45 -0700 (Tue, 08 Jul 2008)
 ulf> New Revision: 22696

 ulf> Log:
 ulf> Add gperf, perfect hash generator

What is it useful for? Does any other packages need it?

 ulf> Added:
 ulf>    trunk/buildroot/package/gperf/
 ulf>    trunk/buildroot/package/gperf/Config.in
 ulf>    trunk/buildroot/package/gperf/gperf.mk

 ulf> Modified:
 ulf>    trunk/buildroot/package/Config.in


 ulf> Changeset:
 ulf> Modified: trunk/buildroot/package/Config.in
 ulf> ===================================================================
 ulf> --- trunk/buildroot/package/Config.in	2008-07-08 20:41:57 UTC (rev 22695)
 ulf> +++ trunk/buildroot/package/Config.in	2008-07-09 04:27:45 UTC (rev 22696)
 ulf> @@ -71,6 +71,7 @@
 ulf>  source "package/dash/Config.in"
 ulf>  source "package/file/Config.in"
 ulf>  source "package/gamin/Config.in"
 ulf> +source "package/gperf/Config.in"

Doesn't it belong under development stuff?

 ulf>  source "package/icu/Config.in"
 ulf>  source "package/ipkg/Config.in"
 ulf>  source "package/kexec/Config.in"

 ulf> Added: trunk/buildroot/package/gperf/Config.in
 ulf> ===================================================================
 ulf> --- trunk/buildroot/package/gperf/Config.in	                        (rev 0)
 ulf> +++ trunk/buildroot/package/gperf/Config.in	2008-07-09 04:27:45 UTC (rev 22696)
 ulf> @@ -0,0 +1,7 @@
 ulf> +config BR2_PACKAGE_GPERF
 ulf> +	bool "gperf"
 ulf> +	default n
 ulf> +	help
 ulf> +	  A 'perfect hash function' generator
 ulf> +
 ulf> +	  $(BR2_GNU_MIRROR)

http://www.gnu.org/software/gperf/ would be better.

 ulf> Added: trunk/buildroot/package/gperf/gperf.mk
 ulf> ===================================================================
 ulf> --- trunk/buildroot/package/gperf/gperf.mk	                        (rev 0)
 ulf> +++ trunk/buildroot/package/gperf/gperf.mk	2008-07-09 04:27:45 UTC (rev 22696)
 ulf> @@ -0,0 +1,22 @@
 ulf> +#############################################################
 ulf> +#
 ulf> +# gperf
 ulf> +#
 ulf> +#############################################################
 ulf> +GPERF_VERSION = 3.0.3
 ulf> +GPERF_SOURCE = gperf-$(GPERF_VERSION).tar.gz
 ulf> +GPERF_SITE = $(BR2_GNU_MIRROR)/gperf
 ulf> +GPERF_AUTORECONF = NO
 ulf> +GPERF_INSTALL_STAGING = YES
 ulf> +GPERF_INSTALL_TARGET = YES

Why install the cross binary under staging?

 ulf> +GPERF_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install 
 ulf> +GPERF_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install 

Trailing spaces.

You're not stripping the binary in TARGET_DIR.

 ulf> +
 ulf> +GPERF_CONF_ENV = 
 ulf> +
 ulf> +GPERF_CONF_OPT = 
 ulf> +
 ulf> +GPERF_DEPENDENCIES = uclibc
 ulf> +
 ulf> +$(eval $(call AUTOTARGETS,package,gperf))
 ulf> +

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2008-07-09  7:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-09  4:27 [Buildroot] svn commit: trunk/buildroot/package: gperf ulf at uclibc.org
2008-07-09  7:14 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87prpn5y2s.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.