From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KETzt-0008QF-RO for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 14:57:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KETzr-0008PS-MP for grub-devel@gnu.org; Thu, 03 Jul 2008 14:57:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KETzp-0008Or-QH for grub-devel@gnu.org; Thu, 03 Jul 2008 14:57:35 -0400 Received: from [199.232.76.173] (port=59260 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KETzp-0008Oo-Jj for grub-devel@gnu.org; Thu, 03 Jul 2008 14:57:33 -0400 Received: from smtp-vbr4.xs4all.nl ([194.109.24.24]:1745) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KETzp-0001bq-BP for grub-devel@gnu.org; Thu, 03 Jul 2008 14:57:33 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr4.xs4all.nl (8.13.8/8.13.8) with ESMTP id m63IvWUV005614 for ; Thu, 3 Jul 2008 20:57:32 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080606162339.GA14162@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 03 Jul 2008 21:05:54 +0200 In-Reply-To: <20080606162339.GA14162@thorin> (Robert Millan's message of "Fri, 6 Jun 2008 18:23:39 +0200") Message-ID: <87prpu4wkt.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] disk/fs_uuid.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 18:57:35 -0000 Robert Millan writes: > This disk driver allows access to partitions that contain a filesystem with > known UUID via "(UUID=xxxxxxx)" syntax. > > The iterator is unimplemented on purpose, because it makes the code smaller > and it isn't useful to waste time inspecting the same devices twice while > scanning for LVM / whatsoever. > > Also note that as it currently stands it is highly inefficient. I can't > understand why; new UUIDs are searched everytime on each open() call, but > this shouldn't be much of an issue since we have a disk cache in kernel to > make that efficient. At least, it isn't e.g. for grub_fs_probe() which is > called multiple times. > > Even with this efficiency problem, since it doesn't interfere with anything > else I'm inclined to commit it, if nobody objects. Why didn't you just extend the search command? I think that would be favorable. -- Marco