From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus =?utf-8?Q?Klotzb=C3=BCcher?= Date: Thu, 22 May 2008 11:59:26 +0200 Subject: [U-Boot-Users] [PATCH] socrates: add USB support In-Reply-To: <1211411753-30092-1-git-send-email-wd@denx.de> (Wolfgang Denk's message of "Thu\, 22 May 2008 01\:15\:53 +0200") References: <1211411753-30092-1-git-send-email-wd@denx.de> Message-ID: <87prrevev5.fsf@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Sergei, Wolfgang, Wolfgang Denk writes: > From: Sergei Poselenov > > Add new configuration variable CONFIG_PCI_OHCI_DEVNO. > In case of several PCI USB controllers on a board this variable > specifys which controller to use. > See doc/README.generic_usb_ohci for details. > > Signed-off-by: Sergei Poselenov > --- > Markus, please note that we added a new configuration variable, > CONFIG_PCI_OHCI_DEVNO in drivers/usb_ohci.c. It addresses the the > case when there are several USB controllers installed on a board > (like on socrates, where 4 PCI OHCI USB controllers are available), > and we need to support a controller instance other than the first > found. > > For socrates, currently it is the 2nd OHCI controller of the 2nd > ISP1562 PCI USB chip (i.e. instance number 3 in the PCI list of OHCI > controllers (0x1131/0x1561)). Patch looks ok (and passed the sequoia test) so: Acked-by: Markus Klotzbuecher But for the future: - The subject is less than meaningful. - I would have really preferred two patches, one for the generic change and one for updating the board config. Wolfgang, do you want to pick this one up directly (preferably with a more meaningful subject) or shall I push it through the usb tree. Either is fine for me. Best regards Markus Klotzb?cher -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de