From: Sergei Organov <osv@javad.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-rev-parse.txt: clarify meaning of rev~ and rev~0.
Date: Fri, 14 Mar 2008 22:11:58 +0300 [thread overview]
Message-ID: <87prtxm875.fsf@osv.gnss.ru> (raw)
In-Reply-To: <alpine.LFD.1.00.0803141141240.3557@woody.linux-foundation.org> (Linus Torvalds's message of "Fri\, 14 Mar 2008 11\:49\:40 -0700 \(PDT\)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Fri, 14 Mar 2008, Sergei Organov wrote:
>>
>> + ... 'rev{tilde}' is equivalent to 'rev{tilde}0'
>> + which in turn is equivalent to 'rev'.
>
> I'd actually prefer to just fix that.
>
> I think it would make more sense to have the same guarantees that rev^
> has, namely to always return a commit. I would also suggest that not
> giving a number would have the same effect of defaulting to 1, not 0.
>
> Right now it's a bit illogical, but at least it's an _undocumented_
> illogical behaviour. If we document it, we should fix it and document the
> logical behaviour instead, no?
>
I entirely agree. I just took (maybe erroneously) Junio's answer to my
original question as "this behavior is by design", assuming some
rationale behind it, so submitted the above patch to documentation.
-- Sergei.
next prev parent reply other threads:[~2008-03-14 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 17:20 [PATCH] git-rev-parse.txt: clarify meaning of rev~ and rev~0 Sergei Organov
2008-03-14 18:49 ` Linus Torvalds
2008-03-14 19:11 ` Sergei Organov [this message]
2008-03-14 20:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prtxm875.fsf@osv.gnss.ru \
--to=osv@javad.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.