From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHbUC-0000Nt-0b for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 04:01:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHbU9-0000MG-30 for grub-devel@gnu.org; Wed, 23 Jan 2008 04:01:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHbU7-0000L2-5p for grub-devel@gnu.org; Wed, 23 Jan 2008 04:01:28 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHbU6-0000Kk-Mi for grub-devel@gnu.org; Wed, 23 Jan 2008 04:01:26 -0500 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JHbU6-0003i5-4a for grub-devel@gnu.org; Wed, 23 Jan 2008 04:01:26 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0N91OH6006429 for ; Wed, 23 Jan 2008 10:01:25 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080119170105.GJ1341@kirkkit.kollasch.net> <20080122200422.GC21526@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Wed, 23 Jan 2008 10:02:41 +0100 In-Reply-To: <20080122200422.GC21526@thorin> (Robert Millan's message of "Tue, 22 Jan 2008 21:04:22 +0100") Message-ID: <87prvssymm.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: UFS (FFS) support seems broken in grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 09:01:29 -0000 Robert Millan writes: > On Wed, Jan 23, 2008 at 02:58:02AM +0800, Bean wrote: >> This patch should fix the problem. > > Nice! > >> -grub_ufs_label (grub_device_t device __attribute ((unused)), >> - char **label __attribute ((unused))) >> +grub_ufs_label (grub_device_t device,char **label) > > Please add a space after the comma ;-) And a changelog entry ;-) -- Marco