From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqsGH-0002KX-1Z for mharc-grub-devel@gnu.org; Sat, 10 Nov 2007 10:28:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqsGF-0002Hg-Ge for grub-devel@gnu.org; Sat, 10 Nov 2007 10:28:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqsGC-0002BP-IH for grub-devel@gnu.org; Sat, 10 Nov 2007 10:28:39 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqsGB-0002AX-Uw for grub-devel@gnu.org; Sat, 10 Nov 2007 10:28:36 -0500 Received: from smtp-vbr7.xs4all.nl ([194.109.24.27]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqsGB-0002mT-Gt for grub-devel@gnu.org; Sat, 10 Nov 2007 10:28:35 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr7.xs4all.nl (8.13.8/8.13.8) with ESMTP id lAAFSX5D053041 for ; Sat, 10 Nov 2007 16:28:34 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20071107205340.GA16687@thorin> <87640bl9ln.fsf@xs4all.nl> <20071109213401.GG23437@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Sat, 10 Nov 2007 16:29:07 +0100 In-Reply-To: <20071109213401.GG23437@thorin> (Robert Millan's message of "Fri, 9 Nov 2007 22:34:01 +0100") Message-ID: <87pryii0fw.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] fix serial console on LinuxBIOS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2007 15:28:39 -0000 Robert Millan writes: > On Fri, Nov 09, 2007 at 04:30:44PM +0100, Marco Gerards wrote: >> Robert Millan writes: >> >> > This patch fixes serial console on LinuxBIOS. >> > >> > I'd appreciate comments (specially on the addition). >> > >> > -- >> > Robert Millan >> > >> > I know my rights; I want my phone call! >> > What use is a phone call, if you are unable to speak? >> > (as seen on /.) >> > >> >> No header ;) > > Uhm what header? That's what I said ;-) What I meant was something like: 2007-10-31 Robert Millan >> > * include/grub/i386/efi/machine.h: New file. >> > * include/grub/i386/linuxbios/machine.h: Likewise. >> > * include/grub/i386/pc/machine.h: Likewise. >> > * include/grub/powerpc/ieee1275/machine.h: Likewise. >> > * include/grub/sparc64/ieee1275/machine.h: Likewise. >> > >> > * term/i386/pc/serial.c: Include . >> > (serial_hw_io_addr): New variable. >> > (serial_hw_get_port): Obtain port address from `serial_hw_io_addr' >> > instead of `(unsigned short *) 0x400'. >> >> This seems fine to me. What is your intended use for machine.h? More >> than just this? > > Situations very similar to this one, in that you just need to change a few > unportable lines while the overall structure of the file remains portable. What I meant was: what should and shouldn't be added to this .h? >> Perhaps we can even use autoconf to define this in config.h? That >> would be better I think. > > autoconf already setups the cpu / machine symlinks. Why ask it to tell the > same info twice? Isn't that what you are doing now? But I have no objections to this fix, please commit it :-) -- Marco