From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HxK2d-000378-5H for mharc-grub-devel@gnu.org; Sun, 10 Jun 2007 05:48:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxK2b-00034g-0j for grub-devel@gnu.org; Sun, 10 Jun 2007 05:48:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxK2Z-00032k-1O for grub-devel@gnu.org; Sun, 10 Jun 2007 05:48:56 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxK2Y-00032N-HS for grub-devel@gnu.org; Sun, 10 Jun 2007 05:48:54 -0400 Received: from smtp-vbr3.xs4all.nl ([194.109.24.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HxK2X-00029j-8T; Sun, 10 Jun 2007 05:48:53 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr3.xs4all.nl (8.13.8/8.13.8) with ESMTP id l5A9mpif027466; Sun, 10 Jun 2007 11:48:52 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: Thomas Schwinge References: <20070609045616.GA9839@ws3.vdp.com> <87645x2ebq.fsf@xs4all.nl> <20070610034253.GA617@ws3.vdp.com> <87y7is1bt3.fsf@xs4all.nl> <20070610091937.GE29831@fencepost.gnu.org> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 10 Jun 2007 11:55:07 +0200 In-Reply-To: <20070610091937.GE29831@fencepost.gnu.org> (Thomas Schwinge's message of "Sun, 10 Jun 2007 11:19:37 +0200") Message-ID: <87ps4416dg.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Cc: The development of GRUB 2 Subject: Re: Update for NTFS file system driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2007 09:48:57 -0000 Thomas Schwinge writes: > Hello! > > On Sun, Jun 10, 2007 at 09:57:44AM +0200, Marco Gerards wrote: >> Bean writes: >> > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: >> >> The normal procedure for patches is to make them consistent with the >> >> GCS (GNU Coding Standards), include a changelog. That way it is >> >> easier to review the patch and to include it in GRUB 2. >> >> The GNU Coding Standards: >> http://www.gnu.org/prep/standards/standards.html >> >> The specific part on ChangeLog entries: >> http://www.gnu.org/prep/standards/standards.html#Change-Logs >> >> The biggest part is on indentation, etc. > > Sorry, but that is also the part which the upstream committers (e.g. you, > or me, or some more others) can trivially fix if you don't like it the > way the first-time contributor has done. That's my idea of this eternal > ``your-formatting-only-does-stop-us-from-committing-your-patch'' thing. > And that is also what I would expect if I were a first-time contributor. > Otherwise I might decide to spend my time elsewhere. The problem is, as you may know, that we have very little time to clean up all the patches. But I am certainly willing to help people wherever possible with these kind of tasks. Besides that, for my feeling the coding style is part of the job. But if you do have the time, please help us out! -- Marco