From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DPktp-0001m6-S6 for mharc-grub-devel@gnu.org; Sun, 24 Apr 2005 13:28:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DPktn-0001lH-OZ for grub-devel@gnu.org; Sun, 24 Apr 2005 13:28:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DPktl-0001ka-UR for grub-devel@gnu.org; Sun, 24 Apr 2005 13:28:03 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DPktl-0000f4-Pt for grub-devel@gnu.org; Sun, 24 Apr 2005 13:28:01 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DPks3-0002E7-Ix for grub-devel@gnu.org; Sun, 24 Apr 2005 13:26:15 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 91DA3A2FB for ; Sun, 24 Apr 2005 19:23:04 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 32032-09 for ; Sun, 24 Apr 2005 19:23:02 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id AC8D9A2F4 for ; Sun, 24 Apr 2005 19:23:02 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 7FB41C047 for ; Sun, 24 Apr 2005 19:23:02 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050422035122.GA12337@miracle> From: Marco Gerards Date: Sun, 24 Apr 2005 19:23:03 +0200 In-Reply-To: <20050422035122.GA12337@miracle> (Hollis Blanchard's message of "Thu, 21 Apr 2005 22:51:22 -0500") Message-ID: <87pswkrsw8.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] PPC cleanups X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2005 17:28:04 -0000 Hollis Blanchard writes: Hi Hollis, Here is my final report. I have tested your patch on the PegasosII. I assume you properly tested it on the G3. You can check in your patch if you make the changes I proposed in this and my previous email. Please update the copyright years of the files you changes, if they are not set correctly. > + grub_ieee1275_finddevice ("/openprom", &openprom); > + smartfw = grub_ieee1275_get_property (openprom, "SmartFirmware-version", > + 0, 0, 0); Please align the make sure `0, 0, 0' are properly aligned with `openprom, "SmartF...'. > + if (smartfw) > + grub_ieee1275_set_flag (GRUB_IEEE1275_0_BASED_PARTITIONS); This did not work on the PegasosII. I fixed this by changing this test to: if (smartfw == 0) grub_ieee1275_set_flag (GRUB_IEEE1275_0_BASED_PARTITIONS); Thanks, Marco