From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.33)
	id 1CI2ee-0002yK-FP
	for mharc-grub-devel@gnu.org; Thu, 14 Oct 2004 06:16:16 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1CI2eY-0002xJ-GA
	for grub-devel@gnu.org; Thu, 14 Oct 2004 06:16:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1CI2eV-0002wC-Nl
	for grub-devel@gnu.org; Thu, 14 Oct 2004 06:16:08 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1CI2eV-0002w2-IJ
	for grub-devel@gnu.org; Thu, 14 Oct 2004 06:16:07 -0400
Received: from [193.45.208.6] (helo=griffin.skarpodata.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34) id 1CI2XK-0004Q5-5J
	for grub-devel@gnu.org; Thu, 14 Oct 2004 06:08:42 -0400
Received: from localhost.localdomain (183.201.216.81.s-s.siw.siwnet.net
	[81.216.201.183])
	by griffin.skarpodata.com (8.12.10/8.12.10) with ESMTP id
	i9EBbRvR009793
	for <grub-devel@gnu.org>; Thu, 14 Oct 2004 13:37:28 +0200
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20041014033756.GA6157@miracle>
From: Johan Rydberg <jrydberg@night.trouble.net>
Date: Thu, 14 Oct 2004 12:10:09 +0200
In-Reply-To: <20041014033756.GA6157@miracle> (Hollis Blanchard's message of
	"Wed, 13 Oct 2004 22:37:56 -0500")
Message-ID: <87pt3lvce6.fsf@night.trouble.net>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [ppc patch] heap memory allocation
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Oct 2004 10:16:13 -0000

Hollis Blanchard <hollis@penguinppc.org> writes:

> [...]
> I've tested this by getting to the GRUB command line on Old World Mac, New
> World Mac, and CodeGen firmware (briQ).
>
> Ok?

I won't address the technical issues in this mail.

> -Hollis
>
> 2004-10-13  Hollis Blanchard  <hollis@penguinppc.org>
>
>     * include/grub/powerpc/ieee1275/ieee1275.h (abort): Add function
>     prototype.
>     * kern/powerpc/ieee1275/init.c (grub_machine_init): Call
>     grub_console_init first.
>     Change the memory range used for grub_ieee1275_claim and
>     grub_mm_init_region.
>     Print an error message if the claim fails.

Looking good Hollis in respect to GCS.  There's just one thing:

> +  /* Apple OF 3.1.1 reserves an extra 0x1000 bytes below the load address
> +   * of an ELF file.  */
> +  heap_len = (grub_addr_t) &_start - 0x1000 - heap_start;

Comments are written without extra prefix stars on new lines.
Like this:

  /* Apple OF 3.1.1 reserves an extra 0x1000 bytes below the load address
     of an ELF file.  */

Other than that, it looks fine to me.  But it's up to the others
to accept the patch.  

I'm pretty sure Marco could make this little change himself if he
chooses to accept the patch.

Best Regards.

~j