From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1C1oWT-000172-Nl for mharc-grub-devel@gnu.org; Mon, 30 Aug 2004 11:56:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C1oWR-00016w-91 for grub-devel@gnu.org; Mon, 30 Aug 2004 11:56:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C1oWP-00016k-JW for grub-devel@gnu.org; Mon, 30 Aug 2004 11:56:43 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C1oWP-00016h-H1 for grub-devel@gnu.org; Mon, 30 Aug 2004 11:56:41 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C1oRW-0005y2-U1 for grub-devel@gnu.org; Mon, 30 Aug 2004 11:51:39 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 4A73F8B1A for ; Mon, 30 Aug 2004 17:50:03 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 30879-03 for ; Mon, 30 Aug 2004 17:50:01 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 9370E84E6 for ; Mon, 30 Aug 2004 17:50:01 +0200 (CEST) Received: from marco.marco-g.com (a82-92-27-129.adsl.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 5D6AAC048 for ; Mon, 30 Aug 2004 17:50:01 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <87vffat3zq.fsf@marco.marco-g.com> <87zn4f17fl.fsf@marco.marco-g.com> <200408301222.55861.okuji@enbug.org> From: Marco Gerards Date: Mon, 30 Aug 2004 15:49:58 +0000 In-Reply-To: <200408301222.55861.okuji@enbug.org> (Yoshinori K. Okuji's message of "Mon, 30 Aug 2004 12:22:55 +0200") Message-ID: <87pt58wrq1.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: JFS support (PATCH) and filesystem improvements X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2004 15:56:43 -0000 "Yoshinori K. Okuji" writes: >> To avoid code duplication I wrote kern/fshelp.c, which has the >> following two functions: > > That is a good idea, but why are the functions in the kernel? Imagine > that GRUB 2 supports TFTP and the user uses GRUB as a network-based > loader. Probably the user does not have to compile the helper > functions, because network-based filesystems are very different at the > implementation level. True. > So I think they should be in a module rather than the kernel. fshelp.mod > sounds good for me. This is a good idea. Is it possible to do this already? How do I make a filesystem depend on fshelp.mod? I assume by using one of its symbols. Is the dependancy code in CVS already? I will change this and make the changes suggested by Thomas before committing this. I have some ideas to make things more efficient for some kinds of filesystems, I will implemented this as well. Thanks, Marco