All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Hui Peng <benquike@gmail.com>
Cc: alex.aring@gmail.com,  stefan@datenfreihafen.org,
	 davem@davemloft.net, edumazet@google.com,  kuba@kernel.org,
	 pabeni@redhat.com, linux-wpan@vger.kernel.org,
	 netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation
Date: Tue, 17 Nov 2026 11:16:47 +0100	[thread overview]
Message-ID: <87qzgjn4og.fsf@bootlin.com> (raw)
In-Reply-To: <87v7809ivq.fsf@bootlin.com> (Miquel Raynal's message of "Sun, 20 Sep 2026 15:01:29 +0200")

On 20/09/2026 at 15:01:29 +02, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> On 19/09/2026 at 22:34:34 GMT, Hui Peng <benquike@gmail.com> wrote:
>
>> In drivers/net/ieee802154/mac802154_hwsim.c, clean up allocated edges
>> and phys on error paths and validate netlink attribute bounds.
>>
>> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
>> Assisted-by: LLM
>> Signed-off-by: Hui Peng <benquike@gmail.com>
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

The commit message is incoherent, I would like to withdraw my tag.

Also, this is the fourth time we receive a similar fix. I already
reviewed this one:
https://lore.kernel.org/all/20260627235805.17310-1-alhouseenyousef@gmail.com/
For which I wait for a v2 which never comes. You can take the feedback
sent there into account (still applies).

Thanks,
Miquèl

      reply	other threads:[~2026-11-17 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 22:34 [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation Hui Peng
2026-09-20 13:01 ` Miquel Raynal
2026-11-17 10:16   ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzgjn4og.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=benquike@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.