All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: tiwai@suse.de, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org, perex@perex.cz
Subject: Re: [PATCH v2] ALSA: compress: Fix task resource leak on copy_to_user() failure
Date: Tue, 17 Nov 2026 16:13:40 +0100	[thread overview]
Message-ID: <87qzgjxzh7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261117062808.2807-1-sreekuttan2156239@gmail.com>

On Tue, 17 Nov 2026 07:28:08 +0100,
Sreeraj S Kurup wrote:
> 
> Hi Takashi,
> 
> Thanks for reviewing my other patches.
> 
> I noticed that this patch is still pending review. 
> Could you please take a look when you get a chance?

I'm still considering whether it's safe.  The open code in the error
path looks a bit scary.

Aren't dma_buf_put() called already in snd_compr_task_free() that is
called from snd_compr_task_free_one()?

Also, a bit concern is that we expose to user-space before actually
installing the file descriptor.  I don't think there will be so much
race here, but just need to be sure...


thanks,

Takashi

  reply	other threads:[~2026-11-17 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 10:45 [PATCH] ALSA: compress: Fix task resource leak on copy_to_user() failure Sreeraj S Kurup
2026-11-13 10:55 ` sashiko-bot
2026-11-13 11:04 ` [PATCH v2] " Sreeraj S Kurup
2026-11-17  6:28   ` Sreeraj S Kurup
2026-11-17 15:13     ` Takashi Iwai [this message]
2026-11-17 16:01       ` Sreeraj S Kurup
2026-11-19 12:57         ` Takashi Iwai
2026-11-19 15:07           ` Sreeraj S Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzgjxzh7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.